From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm-smmu: Document SM61[12]5 GPU SMMU
Date: Thu, 16 Mar 2023 20:29:50 +0100 [thread overview]
Message-ID: <f09e93e1-235a-ea0a-902d-4f41a8c90ee5@linaro.org> (raw)
In-Reply-To: <20230315-topic-kamorta_adrsmmu-v1-1-d1c0dea90bd9@linaro.org>
On 15/03/2023 11:52, Konrad Dybcio wrote:
> Both of these SoCs have a Qualcomm MMU500 implementation of SMMU
> in front of their GPUs that expect 3 clocks. Both of them also have
> an APPS SMMU that expects no clocks. Remove qcom,sm61[12]5-smmu-500
> from the "no clocks" list (intentionally 'breaking' the schema checks
> of APPS SMMU, as now it *can* accept clocks - with the current
> structure of this file it would have taken a wastefully-long time to
> sort this out properly..) and add necessary yaml to describe the
> clocks required by the GPU SMMUs.
> + properties:
> + compatible:
> + items:
> + - enum:
> + - qcom,sm6115-smmu-500
> + - qcom,sm6125-smmu-500
> + - const: qcom,adreno-smmu
> + - const: qcom,smmu-500
> + - const: arm,mmu-500
If you drop the hunk later (from allOf:if), then what clocks do you
expect for non-GPU SMMU?
> + then:
> + properties:
> + clock-names:
> + items:
> + - const: mem
> + - const: hlos
> + - const: iface
> +
> + clocks:
> + items:
> + - description: GPU memory bus clock
> + - description: Voter clock required for HLOS SMMU access
> + - description: Interface clock required for register access
> +
> # Disallow clocks for all other platforms with specific compatibles
> - if:
> properties:
> @@ -394,8 +420,6 @@ allOf:
> - qcom,sdm845-smmu-500
> - qcom,sdx55-smmu-500
> - qcom,sdx65-smmu-500
> - - qcom,sm6115-smmu-500
> - - qcom,sm6125-smmu-500
> - qcom,sm6350-smmu-500
> - qcom,sm6375-smmu-500
> - qcom,sm8350-smmu-500
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-16 19:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 10:52 [PATCH 0/2] SM6115 " Konrad Dybcio
2023-03-15 10:52 ` [PATCH 1/2] dt-bindings: arm-smmu: Document SM61[12]5 " Konrad Dybcio
2023-03-16 19:29 ` Krzysztof Kozlowski [this message]
2023-03-16 21:59 ` Konrad Dybcio
2023-03-17 8:32 ` Krzysztof Kozlowski
2023-03-17 8:32 ` Krzysztof Kozlowski
2023-03-15 10:52 ` [PATCH 2/2] arm64: dts: qcom: sm6115: Add GPUCC and Adreno SMMU Konrad Dybcio
2023-03-27 12:51 ` [PATCH 0/2] SM6115 GPU SMMU Will Deacon
2023-04-05 4:08 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f09e93e1-235a-ea0a-902d-4f41a8c90ee5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®