From: Johannes Berg <johannes@sipsolutions.net>
To: Rosen Penev <rosenp@gmail.com>, linux-wireless@vger.kernel.org
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>,
"open list:BROADCOM BRCM80211 IEEE802.11 WIRELESS DRIVERS"
<brcm80211@lists.linux.dev>,
"open list:BROADCOM BRCM80211 IEEE802.11 WIRELESS DRIVERS"
<brcm80211-dev-list.pdl@broadcom.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH wireless-next] wifi: brcmsmac: use FAM for debug code
Date: Mon, 09 Mar 2026 11:40:12 +0100 [thread overview]
Message-ID: <f09f527c49c8f8998786674a8abd60fcd059f95e.camel@sipsolutions.net> (raw)
In-Reply-To: <20260223030539.19307-1-rosenp@gmail.com>
On Sun, 2026-02-22 at 19:05 -0800, Rosen Penev wrote:
>
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.h
> @@ -43,7 +43,7 @@ struct brcms_timer {
> bool set; /* indicates if timer is active */
> struct brcms_timer *next; /* for freeing on unload */
> #ifdef DEBUG
> - char *name; /* Description of the timer */
> + char name[]; /* Description of the timer */
> #endif
>
Might be better to remove that ifdef too, if only to have cleaner code
and get errors when someone tries to add something after it in non-debug
builds?
johannes
prev parent reply other threads:[~2026-03-09 10:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 3:05 Rosen Penev
2026-03-09 10:40 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f09f527c49c8f8998786674a8abd60fcd059f95e.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®