From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
David Matlack <dmatlack@google.com>
Subject: Re: [PATCH 0/3] KVM: x86/mmu: Cleanups for eager page splitting
Date: Sat, 25 Jun 2022 10:55:04 +0200 [thread overview]
Message-ID: <f0a0ab85-d6de-8f7e-d0be-6c6abffebb33@redhat.com> (raw)
In-Reply-To: <20220624171808.2845941-1-seanjc@google.com>
On 6/24/22 19:18, Sean Christopherson wrote:
> Eager page splitting cleanups for a few minor things that were noted in
> code review but didn't make it into the committed code.
>
> The last patch in particular is a bit more urgent than I first realized.
> I had forgotten that pte_list_desc is now 128 bytes, and I also had a
> brain fart and thought it was just allocating pointers, i.e. 8 bytes.
> In other words, I was thinking the 513 object buffer was "only" wasting
> ~8kb per VM, whereas it actually costs ~64kb per VM.
>
> Sean Christopherson (3):
> KVM: x86/mmu: Avoid subtle pointer arithmetic in kvm_mmu_child_role()
> KVM: x86/mmu: Use "unsigned int", not "u32", for SPTEs' @access info
> KVM: x86/mmu: Buffer nested MMU split_desc_cache only by default
> capacity
>
> arch/x86/kvm/mmu/mmu.c | 53 ++++++++++++++++++++++++++++--------------
> 1 file changed, 35 insertions(+), 18 deletions(-)
>
>
> base-commit: 4b88b1a518b337de1252b8180519ca4c00015c9e
Queued 2+3.
Paolo
prev parent reply other threads:[~2022-06-25 8:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 17:18 Sean Christopherson
2022-06-24 17:18 ` [PATCH 1/3] KVM: x86/mmu: Avoid subtle pointer arithmetic in kvm_mmu_child_role() Sean Christopherson
2022-06-24 17:33 ` David Matlack
2022-06-24 18:50 ` Sean Christopherson
2022-06-24 17:18 ` [PATCH 2/3] KVM: x86/mmu: Use "unsigned int", not "u32", for SPTEs' @access info Sean Christopherson
2022-06-24 17:38 ` David Matlack
2022-06-24 17:18 ` [PATCH 3/3] KVM: x86/mmu: Buffer nested MMU split_desc_cache only by default capacity Sean Christopherson
2022-06-24 17:39 ` David Matlack
2022-06-25 8:55 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0a0ab85-d6de-8f7e-d0be-6c6abffebb33@redhat.com \
--to=pbonzini@redhat.com \
--cc=dmatlack@google.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®