From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A739FC19F2B for ; Fri, 29 Jul 2022 12:01:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235924AbiG2MBH (ORCPT ); Fri, 29 Jul 2022 08:01:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235606AbiG2MBE (ORCPT ); Fri, 29 Jul 2022 08:01:04 -0400 Received: from relay02.th.seeweb.it (relay02.th.seeweb.it [IPv6:2001:4b7a:2000:18::163]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F315028E27; Fri, 29 Jul 2022 05:01:03 -0700 (PDT) Received: from [192.168.1.101] (abxi232.neoplus.adsl.tpnet.pl [83.9.2.232]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id B34871F927; Fri, 29 Jul 2022 14:01:01 +0200 (CEST) Message-ID: Date: Fri, 29 Jul 2022 14:01:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/3] ARM: dts: qcom: msm8960: add reference to sleep_clk Content-Language: en-US To: Dmitry Baryshkov , Krzysztof Kozlowski , Shinjo Park Cc: David Heidelberg , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220728111603.30503-1-peremen@gmail.com> <66e15d42-96fd-5b02-b7c8-a284d3f8d21f@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.07.2022 13:33, Dmitry Baryshkov wrote: > On 28/07/2022 14:51, Krzysztof Kozlowski wrote: >> On 28/07/2022 13:16, Shinjo Park wrote: >>> Change the reference of sleep_clk to the same as qcom-apq8064.dtsi. >> >> You add label, not change something. >> >>> >>> Signed-off-by: Shinjo Park >>> Reviewed-by: David Heidelberg >>> --- >>>   arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi >>> index e8cd1c9c0..991eb1948 100644 >>> --- a/arch/arm/boot/dts/qcom-msm8960.dtsi >>> +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi >>> @@ -71,7 +71,7 @@ pxo_board: pxo_board { >>>               clock-output-names = "pxo_board"; >>>           }; >>>   -        sleep_clk { >>> +        sleep_clk: sleep_clk { >> >> Since you touch the line, make the device node sleep-clk (device node >> names should not have underscores) and mention this in commit msg. > > > Then we are back to the compat issues, since the gcc expects the 'sleep_clk' clock. clock-output-names = "sleep_clk"; Konrad > >