From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F28EC433F5 for ; Fri, 6 May 2022 12:26:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391810AbiEFMaF (ORCPT ); Fri, 6 May 2022 08:30:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1391778AbiEFM34 (ORCPT ); Fri, 6 May 2022 08:29:56 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A985E5D679; Fri, 6 May 2022 05:26:12 -0700 (PDT) Received: from canpemm500007.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KvqXq3chjzhYv2; Fri, 6 May 2022 20:25:47 +0800 (CST) Received: from [10.174.179.215] (10.174.179.215) by canpemm500007.china.huawei.com (7.192.104.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 6 May 2022 20:26:10 +0800 Subject: Re: [PATCH -next] drm/msm: Add missing OF dependency for DRM_MSM To: Dmitry Baryshkov , , , , , CC: , , , References: <20220506020300.20704-1-yuehaibing@huawei.com> From: YueHaibing Message-ID: Date: Fri, 6 May 2022 20:26:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500007.china.huawei.com (7.192.104.62) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/5/6 19:36, Dmitry Baryshkov wrote: > On 06/05/2022 05:03, YueHaibing wrote: >> WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS >>    Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n] >>    Selected by [y]: >>    - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n) >> >> DRM_DP_AUX_BUS depends on OF, so DRM_MSM also should depends on it. > > I think the proper fix would be to make DRM_DP_AUX_BUS depend on OF || COMPILE_TEST rather than just OF Make sense, will do this in v2. > >> >> Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support") >> Signed-off-by: YueHaibing >> --- >>   drivers/gpu/drm/msm/Kconfig | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig >> index 4e0cbd682725..1d710a20ffdd 100644 >> --- a/drivers/gpu/drm/msm/Kconfig >> +++ b/drivers/gpu/drm/msm/Kconfig >> @@ -3,6 +3,7 @@ >>   config DRM_MSM >>       tristate "MSM DRM" >>       depends on DRM >> +    depends on OF >>       depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST >>       depends on COMMON_CLK >>       depends on IOMMU_SUPPORT > >