From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Thara Gopinath <thara.gopinath@linaro.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
daniel.lezcano@linaro.org, rafael@kernel.org,
rui.zhang@intel.com, robh+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] thermal: qcom: lmh: Add support for sm8150
Date: Sat, 4 Dec 2021 14:34:40 +0100 [thread overview]
Message-ID: <f0ae3d36-8317-b297-cc99-645adca1f25c@somainline.org> (raw)
In-Reply-To: <20211202223802.382068-2-thara.gopinath@linaro.org>
Hi,
On 02.12.2021 23:38, Thara Gopinath wrote:
> Add compatible to support LMh for sm8150 SoC.
> sm8150 does not require explicit enabling for various LMh subsystems.
> Move this piece of code under condition that it is executed only
> for sdm845 SoC.
>
> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
> ---
> drivers/thermal/qcom/lmh.c | 61 ++++++++++++++++++++------------------
> 1 file changed, 32 insertions(+), 29 deletions(-)
[...]
> - return ret;
> + if (of_device_is_compatible(np, "qcom,sdm845-lmh")) {
> + if (!qcom_scm_lmh_dcvsh_available())
> + return -EINVAL;
I don't believe this is the correct approach, as different SoCs may
require different sequences of these writes (for example SDM660/MSM8998
seems to only enable the thermal algorithm), and there will (hopefully) be interest
in adding LMH support for more platforms, so perhaps separating this somehow
could keep this a bit cleaner and easier to work with for the next person..
Konrad
next prev parent reply other threads:[~2021-12-04 13:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 22:37 [PATCH 0/3] Extend LMh driver to suppot Qualcomm sm8150 SoC Thara Gopinath
2021-12-02 22:38 ` [PATCH 1/3] thermal: qcom: lmh: Add support for sm8150 Thara Gopinath
2021-12-04 13:34 ` Konrad Dybcio [this message]
2021-12-06 14:22 ` Thara Gopinath
2021-12-02 22:38 ` [PATCH 2/3] arm64: dts: qcom: sm8150: Add support for LMh node Thara Gopinath
2021-12-02 22:38 ` [PATCH 3/3] dt-bindings: thermal: Add sm8150 compatible string for LMh Thara Gopinath
2021-12-13 20:28 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0ae3d36-8317-b297-cc99-645adca1f25c@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®