From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tapio Reijonen <tapio.reijonen@vaisala.com>,
Saravanan Sekar <sravanhome@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] regulator: mpq4210: Use the -ohms feedback divider property
Date: Mon, 14 Sep 2026 08:14:42 +0200 [thread overview]
Message-ID: <f0ae73cf-ac0c-4400-a805-21f1db32b5ff@kernel.org> (raw)
In-Reply-To: <20260913-mpq4210-ohms-fixup-v1-2-dcff627001ff@vaisala.com>
On 13/09/2026 13:40, Tapio Reijonen wrote:
> Follow the binding rename of mps,fb-voltage-divider to
> mps,fb-voltage-divider-ohms.
>
> The old name was never in a release and this driver is its only reader,
> so it is dropped rather than kept as a fallback.
>
> Fixes: 61879d561e91 ("regulator: Add MPS MPQ4210 buck-boost regulator driver")
> Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
> Link: https://lore.kernel.org/r/20260911-gaur-of-satisfying-action-1a3b0f@quoll
> Signed-off-by: Tapio Reijonen <tapio.reijonen@vaisala.com>
> ---
> drivers/regulator/mpq4210.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/mpq4210.c b/drivers/regulator/mpq4210.c
> index 227136d8225805a759d2d6545637858ea7122b89..315f8e02ff2a117e37b32f8a128c9e0feacfac74 100644
> --- a/drivers/regulator/mpq4210.c
> +++ b/drivers/regulator/mpq4210.c
> @@ -144,11 +144,12 @@ static int mpq4210_i2c_probe(struct i2c_client *client)
> u32 r[2];
> int ret;
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-14 6:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 11:40 [PATCH 0/3] regulator: mpq4210: Address the post-merge review comments Tapio Reijonen
2026-09-13 11:40 ` [PATCH 1/3] regulator: dt-bindings: mps,mpq4210: Use the -ohms unit suffix Tapio Reijonen
2026-09-14 6:14 ` Krzysztof Kozlowski
2026-09-13 11:40 ` [PATCH 2/3] regulator: mpq4210: Use the -ohms feedback divider property Tapio Reijonen
2026-09-14 6:14 ` Krzysztof Kozlowski [this message]
2026-09-13 11:40 ` [PATCH 3/3] regulator: mpq4210: Drop the mod_devicetable.h include Tapio Reijonen
2026-09-14 7:22 ` Uwe Kleine-König
2026-09-14 10:13 ` [PATCH 0/3] regulator: mpq4210: Address the post-merge review comments Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0ae73cf-ac0c-4400-a805-21f1db32b5ff@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sravanhome@gmail.com \
--cc=tapio.reijonen@vaisala.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®