From: Arseniy Krasnov <avkrasnov@sberdevices.ru>
To: Stefan Hajnoczi <stefanha@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Bobby Eshleman <bobby.eshleman@bytedance.com>
Cc: <kvm@vger.kernel.org>,
<virtualization@lists.linux-foundation.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel@sberdevices.ru>, <oxffffaa@gmail.com>,
<avkrasnov@sberdevices.ru>
Subject: [RFC PATCH v5 0/2] allocate multiple skbuffs on tx
Date: Wed, 22 Mar 2023 21:34:23 +0300 [thread overview]
Message-ID: <f0b283a1-cc63-dc3d-cc0c-0da7f684d4d2@sberdevices.ru> (raw)
This adds small optimization for tx path: instead of allocating single
skbuff on every call to transport, allocate multiple skbuff's until
credit space allows, thus trying to send as much as possible data without
return to af_vsock.c.
Also this patchset includes second patch which adds check and return from
'virtio_transport_get_credit()' and 'virtio_transport_put_credit()' when
these functions are called with 0 argument. This is needed, because zero
argument makes both functions to behave as no-effect, but both of them
always tries to acquire spinlock. Moreover, first patch always calls
function 'virtio_transport_put_credit()' with zero argument in case of
successful packet transmission.
Link to v1:
https://lore.kernel.org/netdev/2c52aa26-8181-d37a-bccd-a86bd3cbc6e1@sberdevices.ru/
Link to v2:
https://lore.kernel.org/netdev/ea5725eb-6cb5-cf15-2938-34e335a442fa@sberdevices.ru/
Link to v3:
https://lore.kernel.org/netdev/f33ef593-982e-2b3f-0986-6d537a3aaf08@sberdevices.ru/
Link to v4:
https://lore.kernel.org/netdev/0e0c1421-7cdc-2582-b120-cad6f42824bb@sberdevices.ru/
Changelog:
v1 -> v2:
- If sent something, return number of bytes sent (even in
case of error). Return error only if failed to sent first
skbuff.
v2 -> v3:
- Handle case when transport callback returns unexpected value which
is not equal to 'skb->len'. Break loop.
- Don't check for zero value of 'rest_len' before calling
'virtio_transport_put_credit()'. Decided to add this check directly
to 'virtio_transport_put_credit()' in separate patch.
v3 -> v4:
- Use WARN_ONCE() to handle case when transport callback returns
unexpected value.
- Remove useless 'ret = -EFAULT;' assignment for case above.
v4 -> v5:
- Remove extra 'ret' initialization.
- Remove empty extra line before 'if (ret < 0)'.
- Add R-b tag for the first patch.
- Add second patch, thus creating patchset of 2 patches.
Arseniy Krasnov (2):
virtio/vsock: allocate multiple skbuffs on tx
virtio/vsock: check argument to avoid no effect call
net/vmw_vsock/virtio_transport_common.c | 63 +++++++++++++++++++------
1 file changed, 49 insertions(+), 14 deletions(-)
--
2.25.1
next reply other threads:[~2023-03-22 18:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 18:34 Arseniy Krasnov [this message]
2023-03-22 18:35 ` [RFC PATCH v5 1/2] virtio/vsock: " Arseniy Krasnov
2023-03-22 18:36 ` [RFC PATCH v5 2/2] virtio/vsock: check argument to avoid no effect call Arseniy Krasnov
2023-03-23 9:29 ` Stefano Garzarella
2023-03-23 10:01 ` [RFC PATCH v5 0/2] allocate multiple skbuffs on tx Arseniy Krasnov
2023-03-23 10:48 ` Stefano Garzarella
2023-03-23 10:53 ` Arseniy Krasnov
2023-03-23 11:11 ` Stefano Garzarella
2023-03-23 11:34 ` Arseniy Krasnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0b283a1-cc63-dc3d-cc0c-0da7f684d4d2@sberdevices.ru \
--to=avkrasnov@sberdevices.ru \
--cc=bobby.eshleman@bytedance.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@sberdevices.ru \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oxffffaa@gmail.com \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®