From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E27FD2BE035 for ; Fri, 6 Mar 2026 13:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772802007; cv=none; b=kkyT/K3QAvcc5yTiDXVW7rT8HnWsyD+82YizddPcv83E1SutKdsMRsjrVUwJxGXsTOFkX6ONZSGfTol9Y+wLxVmq7CyGM05ks84NlQ0r/jYLV8D4d0IPEXVx6y6XRUBgXFdKMdU8jD59np5n9uz6fv97IteECKkz1+sZhiw2Gts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772802007; c=relaxed/simple; bh=To3oybs//nRCsZfr15UepiH/PCQfLOLM9azq0B2N2sk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g44kyMuWdcyPeSdhMuP3PxnHd7rlsbssKIIYSR+HCyx0EdbzQpf9QwXfGRqtjXirZkpfN1K47C2tjiShKnwxPHVgr2/6aO2uezQJNqj71NAt6F6UAkvnD2qPyGZAzpGvUFdP7qCuD3uE1MbNCkD0V3b25hoB62JBZXknLvf4DY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Owvsm2vG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eJWjt9FJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Owvsm2vG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eJWjt9FJ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626BbGPf4150971 for ; Fri, 6 Mar 2026 13:00:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= To3oybs//nRCsZfr15UepiH/PCQfLOLM9azq0B2N2sk=; b=Owvsm2vGUrvJE22y WzZJ+aJ+0j58D0sAjmnnynh4XZS6ynoR08wwFD1ZFCdW7LDVOH91FUUesARe83l1 U/my4EWv57ILb7REGIrqMtB+VIGUX/UhQFBNdKztCh9/XEmtektKN8+6BBP9j7xU T0G6BTE6YlL3ZuDgBvf1K3khj5/DlrEMZ5VyvklyKNLKdMM3yLy/xSgamr1wiFlI 6d1dTK/ri2mWsxDRpj/6rJjtSQLKYac8elIGvSBjmEZMCmaqKx+ZcibVb3S1UNpf /nBtTcjVRh5Y9mQr95YYUpVhbZA8UeBZMVveRJnEEjL6QcGihvb31V2x38kSNetS JrL7Pw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqf25u7hq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 13:00:04 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ae3badc00dso72211795ad.3 for ; Fri, 06 Mar 2026 05:00:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772802004; x=1773406804; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=To3oybs//nRCsZfr15UepiH/PCQfLOLM9azq0B2N2sk=; b=eJWjt9FJwhipgu2IQeDXsXKtFH4Clcfkz+7j10nCyh4zDZcEri36J9MaruZqU2H4Re jQwuzMhdqQBof1ztW+J7mO5GpnqmQ19GlhBzNHpVQ/9gdpnLRw2ztg7pbdE++C1YIZy/ KOqFhQZ/74n+oZe2nL2nf5HLLS7PgkWn4mVR2L9myQ3PMzDKxdSTakxHO6ClieaXOMVi cNGPkgIXCLyuLwGfd1XPYRq5bFN8RfSfZClvkHopg+NQb4vJI43x/oqkFLy3Mpb/oX/e cxV+2M3xXWBoHvuXE7uYlO0wUCuqXg9khdyFkCD0pUvT7TWDzJgwhoLAOxCKHaTmJI5z 2gPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772802004; x=1773406804; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=To3oybs//nRCsZfr15UepiH/PCQfLOLM9azq0B2N2sk=; b=gB/9VmIzESFnUNrinK+UYzXR47W8wBxYqNB9c8W1UymvvPCrVw4/J7qL7VhM0pnbou Gmadlg3cTAdrIiZGR79dt+sSNzcwyLrHn1ASXiVc5fvRRD7GNR6Q5+3P3+KuCQo2Jty/ FkUK/O/BaYdXJncPJthWo86gL1Tl9aLU/bZXzlUip/shHynps78t94mJNKl+56ReJYXs F6fssMHTFde37DfS39CevdRoR8/uJ3URuWwFwtkyUKYLdjOb8jv2RBl3/Cmpz1/1lb9w 5Jijrxp0XnvWeUqbiNN2B+l+p/xqR1tMcipF21r27AeEr18pgvVY/lZ7G6lXP3JyXiqr D7EA== X-Forwarded-Encrypted: i=1; AJvYcCXEM12YBKnKvaYjsW0vSzUba+JpgY6fJ7lXUh1+fUmt83ccOw/dlxQ6padXmJvPkpboDEXXi8eHIePlJCs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2rhWOZfYtHW+Ba3my2d+puPpy4dp4wU8Hw6tGavKlirhC457s Pf/sKCxM9QEHUHYcCRWqBMYvf57zn2ZqbbWYvGoQ1QHPtKAz1xU0qRjllIkGprQLEEp+fSPzJpf Zwp2niG7Kak6yP3yos1SlIuY1lfnVH104Eyl1Jd5HLpwOeH5gaS95M5bfBA2c7wZ8SBU= X-Gm-Gg: ATEYQzwj3TY4uG51IRfcem6e5FjB3LoQvY1yBvxjRP6abAPMr99vjlU00q4yMttnyIo xITgL9bAajBIYq32DOBsUGslDWs27hpn0LP5IEKhCJ2NkHxftnpErHtAfixOYoUjpL7fYjkCHcV mZJSyD/lfukL0m/21PRyxcfspCz97LfmVlQOEtyQo328jGOjGB18HWHB51DKYN5KYRK2yrT8zT1 rahRYNsr1uxbRDbIuXGxRPIQ7AKvlz5Lh7ZageTSdd0SZwxyvTHXPbNVEOqlZmEO8Ro73zv64mw hRa5W4VVF7SUKikuslwWJqlW5o5/JaiNixbt1i/z4TJhCX4QfVA6SZ2609jcMJ1QX1pM8rKaEWf F4TE1FPtTe+zKGg6kIGVFc5+PTcwr+S9CinOJEeFQH3RQRNe78t8mUNYDAUVTzj1lZBp1vyVjEF uYdYhD4SxAHvQ= X-Received: by 2002:a17:903:41d0:b0:2ae:6192:8da4 with SMTP id d9443c01a7336-2ae8236711cmr24147105ad.2.1772802004309; Fri, 06 Mar 2026 05:00:04 -0800 (PST) X-Received: by 2002:a17:903:41d0:b0:2ae:6192:8da4 with SMTP id d9443c01a7336-2ae8236711cmr24146695ad.2.1772802003793; Fri, 06 Mar 2026 05:00:03 -0800 (PST) Received: from [10.133.33.226] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83f759fdsm28945635ad.57.2026.03.06.04.59.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2026 05:00:03 -0800 (PST) Message-ID: Date: Fri, 6 Mar 2026 20:59:55 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 04/11] scsi: ufs: core: Add support for TX Equalization To: Bean Huo , avri.altman@wdc.com, bvanassche@acm.org, beanhuo@micron.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Peter Wang , "Bao D. Nguyen" , Adrian Hunter , open list References: <20260304135313.413688-1-can.guo@oss.qualcomm.com> <20260304135313.413688-5-can.guo@oss.qualcomm.com> <5f998c89c2939baa2939a1ad8942b015d3ccccfc.camel@iokpp.de> Content-Language: en-US From: Can Guo In-Reply-To: <5f998c89c2939baa2939a1ad8942b015d3ccccfc.camel@iokpp.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: S_LfI9dCAgCzf4Ijgt958_RF9cRhte2j X-Authority-Analysis: v=2.4 cv=Uvdu9uwB c=1 sm=1 tr=0 ts=69aacfd4 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=oayze6Pay6DZa2MYWdUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDEyNCBTYWx0ZWRfX1s/65U5OsNhT WV8jpv+M+z0Wy3jDIEIRMDXVr9FlxyOPz+TK9JO8yvbTfIR4LZaoxhdlXUVR1j31hhr9et991d7 /0vAN60Ea5PE1xi2yHWQ2oWl2+t5XHGllNBET4RBL6AIZrORDRNwsaUiw/pc3OX2SRoMNQexSgQ jSqlaQNevj4oXKjgOlokLPUu6QKJApK/2LAFJ2V8vMzhmAjYdpJyxC7CqN9T3B3jQBoRbcL0XYO BgYeVlJNkp+QygmHVW0dT97FI3toVfX/caR6fy10PuvbDPV2a5/W6rWrPlazLXhLGUDn7BIn218 1qRRIKKGvbjARIGEWNvA1afY8kt205DtMsfTcI0+7wsJzjEwkM4grJKAI+Mg79uIP4HiijNjl4C XrrJyn+VWFyhu0l9bkJdf9ifoK2znRlH32SdMojOXnAnzQsZbNHxpHPQAuUPnr2OKPbDBYnzynA rNsyfjXC3AQwG91qQUg== X-Proofpoint-GUID: S_LfI9dCAgCzf4Ijgt958_RF9cRhte2j X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_04,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 malwarescore=0 spamscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060124 On 3/6/2026 5:50 AM, Bean Huo wrote: > On Wed, 2026-03-04 at 05:53 -0800, Can Guo wrote: >> + */ >> +static int ufshcd_tx_eqtr_data_init(struct ufs_hba *hba, >> +                                   struct ufshcd_tx_eq_params *params, >> +                                   struct tx_eqtr_iter *h_iter, >> +                                   struct tx_eqtr_iter *d_iter) >> +{ >> +       u32 cap; >> +       int ret; >> + >> +       if (!hba->host_preshoot_cap) { >> +               ret = ufshcd_dme_get(hba, >> UIC_ARG_MIB(TX_HS_PRESHOOT_SETTING_CAP), &cap); >> +               if (ret) >> +                       return ret; >> + >> +               hba->host_preshoot_cap = cap & TX_EQTR_CAP_MASK; >> +       } >> + >> +       if (!hba->host_deemphasis_cap) { >> +               ret = ufshcd_dme_get(hba, >> UIC_ARG_MIB(TX_HS_DEEMPHASIS_SETTING_CAP), &cap); >> +               if (ret) >> +                       return ret; >> + >> +               hba->host_deemphasis_cap = cap & TX_EQTR_CAP_MASK; >> +       } >> + >> +       if (!hba->device_preshoot_cap) { >> +               ret = ufshcd_dme_peer_get(hba, >> UIC_ARG_MIB(TX_HS_PRESHOOT_SETTING_CAP), &cap); >> +               if (ret) >> +                       return ret; >> + >> +               hba->device_preshoot_cap = cap & TX_EQTR_CAP_MASK; >> +       } >> + >> +       if (!hba->device_deemphasis_cap) { >> +               ret = ufshcd_dme_peer_get(hba, >> UIC_ARG_MIB(TX_HS_DEEMPHASIS_SETTING_CAP), &cap); >> +               if (ret) >> +                       return ret; >> + >> +               hba->device_deemphasis_cap = cap & TX_EQTR_CAP_MASK; >> +       } >> + >> +       memset(params->host, 0, sizeof(params->host)); >> +       memset(params->device, 0, sizeof(params->device)); >> +       memset(params->host_eqtr_record, 0xFF, sizeof(params- >>> host_eqtr_record)); >> +       memset(params->device_eqtr_record, 0xFF, sizeof(params- >>> device_eqtr_record)); >> + >> +       memset(h_iter, 0, sizeof(struct tx_eqtr_iter)); >> +       memset(d_iter, 0, sizeof(struct tx_eqtr_iter)); >> + >> +       h_iter->num_lanes = params->tx_lanes; >> +       d_iter->num_lanes = params->rx_lanes; >> + >> +       /* >> +        * Support PreShoot & DeEmphasis of value 0 is mandatory, hence they >> are >> +        * not reflected in PreShoot/DeEmphasis capabilities. Left shift the >> +        * capability bitmap by 1 and set bit[0] to reflect value 0 is >> +        * supported, such that test_bit() can be used later for convenience. >> +        */ >> +       h_iter->preshoot_bitmap = (hba->host_preshoot_cap << 0x1) | 0x1; >> +       h_iter->deemphasis_bitmap = (hba->host_deemphasis_cap << 0x1) | 0x1; >> +       d_iter->preshoot_bitmap = (hba->device_preshoot_cap << 0x1) | 0x1; >> +       d_iter->deemphasis_bitmap = (hba->device_deemphasis_cap << 0x1) | 0x1; >> + >> +       return ret; > > ret is returned without guaranteed initialization when caps are already cached. Good catch. Thanks, Can Guo. > >> +}