From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Aaron Ma <aaron.ma@canonical.com>,
mathias.nyman@intel.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] usb: xhci: fix uninitialized completion when USB3 port got wrong status
Date: Tue, 23 Oct 2018 13:42:39 +0300 [thread overview]
Message-ID: <f0bc503c-f128-d427-37ce-8b609319dc13@linux.intel.com> (raw)
In-Reply-To: <1540230167-12528-1-git-send-email-aaron.ma@canonical.com>
On 22.10.2018 20:42, Aaron Ma wrote:
> Realtek USB3.0 Card Reader [0bda:0328] reports wrong port status on
> Cannon lake PCH USB3.1 xHCI [8086:a36d] after resume from S3,
> after clear port reset it works fine.
>
> Since this device is registered on USB3 roothub at boot,
> when port status reports not superspeed, xhci_get_port_status will call
> an uninitialized completion in bus_state[0].
> Kernel will hang because of NULL pointer.
>
> Restrict the USB2 resume status check in USB2 roothub to fix hang issue.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
Thanks, adding to queue, will send forward after rc1
-Mathias
prev parent reply other threads:[~2018-10-23 10:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 17:42 Aaron Ma
2018-10-22 17:42 ` [PATCH v2 2/2] usb: xhci: fix timeout for transition from RExit to U0 Aaron Ma
2018-10-23 10:43 ` Mathias Nyman
2018-10-23 10:42 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0bc503c-f128-d427-37ce-8b609319dc13@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=aaron.ma@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®