From: Matthias Brugger <mbrugger@suse.com>
To: Frank Wunderlich <frank-w@public-files.de>, matthias.bgg@kernel.org
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Gene Chen <gene_chen@richtek.com>, Axel Lin <axel.lin@ingics.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
John Crispin <john@phrozen.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Chen Zhong <chen.zhong@mediatek.com>,
Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
Subject: Re: Aw: [PATCH v2 3/3] regulator: mt6323: Add OF match table
Date: Sun, 10 Jan 2021 19:48:01 +0100 [thread overview]
Message-ID: <f0be4573-685a-33ae-16a0-d483272571b7@suse.com> (raw)
In-Reply-To: <trinity-5d8f37cd-9d0e-4790-baf9-30b8ea4bc743-1610210692928@3c-app-gmx-bap17>
On 09/01/2021 17:44, Frank Wunderlich wrote:
> Hi
>
>> Gesendet: Samstag, 09. Januar 2021 um 12:26 Uhr
>> Von: matthias.bgg@kernel.org
>
>> Changes in v2:
>> - check for CONFIG_OF
>> - add Fixes tag
>
>> --- a/drivers/regulator/mt6323-regulator.c
>> +++ b/drivers/regulator/mt6323-regulator.c
>> @@ -406,9 +406,18 @@ static const struct platform_device_id mt6323_platform_ids[] = {
>> };
>> MODULE_DEVICE_TABLE(platform, mt6323_platform_ids);
>>
>> +#ifdef CONFIG_OF
>> +static const struct of_device_id mt6323_of_match[] = {
>> + { .compatible = "mediatek,mt6323-regulator", },
>> + { /* sentinel */ },
>> +};
>> +MODULE_DEVICE_TABLE(of, mt6323_of_match);
>> +#endif
>> +
>> static struct platform_driver mt6323_regulator_driver = {
>> .driver = {
>> .name = "mt6323-regulator",
>> + .of_match_table = of_match_ptr(mt6323_of_match),
>
> imho check for CONFIG_OF is here needed too, else mt6323_of_match is referenced but undefined
>
No, of_match_ptr already takes care of this:
https://elixir.bootlin.com/linux/latest/source/include/linux/of.h#L998
Regards,
Matthias
next prev parent reply other threads:[~2021-01-10 18:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 11:26 [PATCH v2 1/3] regulator: mt6360: " matthias.bgg
2021-01-09 11:26 ` [PATCH v2 2/3] regulator: mt6358: " matthias.bgg
2021-01-09 11:26 ` [PATCH v2 3/3] regulator: mt6323: " matthias.bgg
2021-01-09 16:44 ` Aw: " Frank Wunderlich
2021-01-10 18:48 ` Matthias Brugger [this message]
2021-01-11 2:18 ` [PATCH v2 1/3] regulator: mt6360: " gene_chen(陳俊宇)
2021-01-11 10:08 ` Matthias Brugger
2021-01-11 10:32 ` Vaittinen, Matti
2021-01-11 12:38 ` Matthias Brugger
2021-01-11 12:53 ` Vaittinen, Matti
2021-01-11 14:42 ` Matthias Brugger
2021-01-11 16:41 ` Mark Brown
2021-01-12 9:54 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0be4573-685a-33ae-16a0-d483272571b7@suse.com \
--to=mbrugger@suse.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=chen.zhong@mediatek.com \
--cc=frank-w@public-files.de \
--cc=gene_chen@richtek.com \
--cc=hsin-hsiung.wang@mediatek.com \
--cc=john@phrozen.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=matthias.bgg@kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®