From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>,
roopa@cumulusnetworks.com, davem@davemloft.net, kuba@kernel.org,
jiri@resnulli.us, ivecera@redhat.com, andrew@lunn.ch,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next v4 07/12] bridge: switchdev: mrp: Extend MRP API for switchdev for MRP Interconnect
Date: Tue, 14 Jul 2020 16:16:30 +0300 [thread overview]
Message-ID: <f0c67d68-b181-4a79-9d7c-a8810c3bfd70@cumulusnetworks.com> (raw)
In-Reply-To: <20200714073458.1939574-8-horatiu.vultur@microchip.com>
On 14/07/2020 10:34, Horatiu Vultur wrote:
> Implement the MRP API for interconnect switchdev. Similar with the other
> br_mrp_switchdev function, these function will just eventually call the
> switchdev functions: switchdev_port_obj_add/del.
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> net/bridge/br_mrp_switchdev.c | 62 +++++++++++++++++++++++++++++++++++
> net/bridge/br_private_mrp.h | 7 ++++
> 2 files changed, 69 insertions(+)
>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> diff --git a/net/bridge/br_mrp_switchdev.c b/net/bridge/br_mrp_switchdev.c
> index 0da68a0da4b5a..ed547e03ace17 100644
> --- a/net/bridge/br_mrp_switchdev.c
> +++ b/net/bridge/br_mrp_switchdev.c
> @@ -107,6 +107,68 @@ int br_mrp_switchdev_set_ring_state(struct net_bridge *br,
> return 0;
> }
>
> +int br_mrp_switchdev_set_in_role(struct net_bridge *br, struct br_mrp *mrp,
> + u16 in_id, u32 ring_id,
> + enum br_mrp_in_role_type role)
> +{
> + struct switchdev_obj_in_role_mrp mrp_role = {
> + .obj.orig_dev = br->dev,
> + .obj.id = SWITCHDEV_OBJ_ID_IN_ROLE_MRP,
> + .in_role = role,
> + .in_id = mrp->in_id,
> + .ring_id = mrp->ring_id,
> + .i_port = rtnl_dereference(mrp->i_port)->dev,
> + };
> + int err;
> +
> + if (role == BR_MRP_IN_ROLE_DISABLED)
> + err = switchdev_port_obj_del(br->dev, &mrp_role.obj);
> + else
> + err = switchdev_port_obj_add(br->dev, &mrp_role.obj, NULL);
> +
> + return err;
> +}
> +
> +int br_mrp_switchdev_set_in_state(struct net_bridge *br, struct br_mrp *mrp,
> + enum br_mrp_in_state_type state)
> +{
> + struct switchdev_obj_in_state_mrp mrp_state = {
> + .obj.orig_dev = br->dev,
> + .obj.id = SWITCHDEV_OBJ_ID_IN_STATE_MRP,
> + .in_state = state,
> + .in_id = mrp->in_id,
> + };
> + int err;
> +
> + err = switchdev_port_obj_add(br->dev, &mrp_state.obj, NULL);
> +
> + if (err && err != -EOPNOTSUPP)
> + return err;
> +
> + return 0;
> +}
> +
> +int br_mrp_switchdev_send_in_test(struct net_bridge *br, struct br_mrp *mrp,
> + u32 interval, u8 max_miss, u32 period)
> +{
> + struct switchdev_obj_in_test_mrp test = {
> + .obj.orig_dev = br->dev,
> + .obj.id = SWITCHDEV_OBJ_ID_IN_TEST_MRP,
> + .interval = interval,
> + .max_miss = max_miss,
> + .in_id = mrp->in_id,
> + .period = period,
> + };
> + int err;
> +
> + if (interval == 0)
> + err = switchdev_port_obj_del(br->dev, &test.obj);
> + else
> + err = switchdev_port_obj_add(br->dev, &test.obj, NULL);
> +
> + return err;
> +}
> +
> int br_mrp_port_switchdev_set_state(struct net_bridge_port *p,
> enum br_mrp_port_state_type state)
> {
> diff --git a/net/bridge/br_private_mrp.h b/net/bridge/br_private_mrp.h
> index 23da2f956ad0e..0d554ef88db85 100644
> --- a/net/bridge/br_private_mrp.h
> +++ b/net/bridge/br_private_mrp.h
> @@ -72,6 +72,13 @@ int br_mrp_port_switchdev_set_state(struct net_bridge_port *p,
> enum br_mrp_port_state_type state);
> int br_mrp_port_switchdev_set_role(struct net_bridge_port *p,
> enum br_mrp_port_role_type role);
> +int br_mrp_switchdev_set_in_role(struct net_bridge *br, struct br_mrp *mrp,
> + u16 in_id, u32 ring_id,
> + enum br_mrp_in_role_type role);
> +int br_mrp_switchdev_set_in_state(struct net_bridge *br, struct br_mrp *mrp,
> + enum br_mrp_in_state_type state);
> +int br_mrp_switchdev_send_in_test(struct net_bridge *br, struct br_mrp *mrp,
> + u32 interval, u8 max_miss, u32 period);
>
> /* br_mrp_netlink.c */
> int br_mrp_ring_port_open(struct net_device *dev, u8 loc);
>
next prev parent reply other threads:[~2020-07-14 13:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 7:34 [PATCH net-next v4 00/12] bridge: mrp: Add support for interconnect ring Horatiu Vultur
2020-07-14 7:34 ` [PATCH net-next v4 01/12] switchdev: mrp: Extend switchdev API for MRP Interconnect Horatiu Vultur
2020-07-14 13:30 ` Nikolay Aleksandrov
2020-07-14 7:34 ` [PATCH net-next v4 02/12] bridge: uapi: mrp: Extend MRP attributes for MRP interconnect Horatiu Vultur
2020-07-14 13:14 ` Nikolay Aleksandrov
2020-07-14 7:34 ` [PATCH net-next v4 03/12] bridge: mrp: Extend bridge interface Horatiu Vultur
2020-07-14 13:14 ` Nikolay Aleksandrov
2020-07-14 7:34 ` [PATCH net-next v4 04/12] bridge: mrp: Extend br_mrp for MRP interconnect Horatiu Vultur
2020-07-14 13:15 ` Nikolay Aleksandrov
2020-07-14 7:34 ` [PATCH net-next v4 05/12] bridge: mrp: Rename br_mrp_port_open to br_mrp_ring_port_open Horatiu Vultur
2020-07-14 13:15 ` Nikolay Aleksandrov
2020-07-14 7:34 ` [PATCH net-next v4 06/12] bridge: mrp: Add br_mrp_in_port_open function Horatiu Vultur
2020-07-14 13:16 ` Nikolay Aleksandrov
2020-07-14 7:34 ` [PATCH net-next v4 07/12] bridge: switchdev: mrp: Extend MRP API for switchdev for MRP Interconnect Horatiu Vultur
2020-07-14 13:16 ` Nikolay Aleksandrov [this message]
2020-07-14 7:34 ` [PATCH net-next v4 08/12] bridge: mrp: Implement the MRP Interconnect API Horatiu Vultur
2020-07-14 13:23 ` Nikolay Aleksandrov
2020-07-14 7:34 ` [PATCH net-next v4 09/12] bridge: mrp: Extend MRP netlink interface for configuring MRP interconnect Horatiu Vultur
2020-07-14 13:24 ` Nikolay Aleksandrov
2020-07-14 7:34 ` [PATCH net-next v4 10/12] bridge: uapi: mrp: Extend MRP_INFO attributes for interconnect status Horatiu Vultur
2020-07-14 13:24 ` Nikolay Aleksandrov
2020-07-14 7:34 ` [PATCH net-next v4 11/12] bridge: mrp: Extend br_mrp_fill_info Horatiu Vultur
2020-07-14 13:24 ` Nikolay Aleksandrov
2020-07-14 7:34 ` [PATCH net-next v4 12/12] net: bridge: Add port attribute IFLA_BRPORT_MRP_IN_OPEN Horatiu Vultur
2020-07-14 13:29 ` Nikolay Aleksandrov
2020-07-14 15:07 ` Horatiu Vultur
2020-07-14 15:33 ` Nikolay Aleksandrov
2020-07-14 15:53 ` Horatiu Vultur
2020-07-14 20:47 ` [PATCH net-next v4 00/12] bridge: mrp: Add support for interconnect ring David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0c67d68-b181-4a79-9d7c-a8810c3bfd70@cumulusnetworks.com \
--to=nikolay@cumulusnetworks.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=horatiu.vultur@microchip.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®