From: "rocky.hao" <rocky.hao@rock-chips.com>
To: Caesar Wang <wxt@rock-chips.com>,
rui.zhang@intel.com, edubezval@gmail.com, heiko@sntech.de,
robh+dt@kernel.org, mark.rutland@arm.com,
catalin.marinas@arm.com, will.deacon@arm.com
Cc: huangtao@rock-chips.com, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org, shawn.lin@rock-chips.com,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
cl@rock-chips.com, william.wu@rock-chips.com,
jay.xu@rock-chips.com, xxx@rock-chips.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/5] arm64: dts: rockchip: add thermal nodes for rk3328 SoC
Date: Fri, 11 Aug 2017 17:46:55 +0800 [thread overview]
Message-ID: <f0c7ab33-1b7b-8b9d-fd20-aa84001014cc@rock-chips.com> (raw)
In-Reply-To: <b9f85901-2fb5-d4ed-503c-1c4684d821e7@rock-chips.com>
Hi Caesar,
Thanks for your comments.
Best Regards,
Rocky
在 2017/8/11 14:44, Caesar Wang 写道:
> 在 2017年08月04日 16:06, Rocky Hao 写道:
>> add thermal zone and dynamic CPU power coefficients for rk3328
>>
>> Signed-off-by: Rocky Hao <rocky.hao@rock-chips.com>
>> ---
>> Change in v2:
>> - remove gerrit Change-Id
>>
>> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 43
>> ++++++++++++++++++++++++++++++++
>> 1 file changed, 43 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>> b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>> index 186fb93fdffd..68829f808320 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>> @@ -47,6 +47,7 @@
>> #include <dt-bindings/pinctrl/rockchip.h>
>> #include <dt-bindings/power/rk3328-power.h>
>> #include <dt-bindings/soc/rockchip,boot-mode.h>
>> +#include <dt-bindings/thermal/thermal.h>
>> / {
>> compatible = "rockchip,rk3328";
>> @@ -74,6 +75,8 @@
>> compatible = "arm,cortex-a53", "arm,armv8";
>> reg = <0x0 0x0>;
>> clocks = <&cru ARMCLK>;
>> + #cooling-cells = <2>; /* min followed by max */
>> + dynamic-power-coefficient = <120>;
>> enable-method = "psci";
>> next-level-cache = <&l2>;
>> };
>> @@ -83,6 +86,7 @@
>> compatible = "arm,cortex-a53", "arm,armv8";
>> reg = <0x0 0x1>;
>> clocks = <&cru ARMCLK>;
>> + dynamic-power-coefficient = <120>;
>> enable-method = "psci";
>> next-level-cache = <&l2>;
>> };
>> @@ -92,6 +96,7 @@
>> compatible = "arm,cortex-a53", "arm,armv8";
>> reg = <0x0 0x2>;
>> clocks = <&cru ARMCLK>;
>> + dynamic-power-coefficient = <120>;
>> enable-method = "psci";
>> next-level-cache = <&l2>;
>> };
>> @@ -101,6 +106,7 @@
>> compatible = "arm,cortex-a53", "arm,armv8";
>> reg = <0x0 0x3>;
>> clocks = <&cru ARMCLK>;
>> + dynamic-power-coefficient = <120>;
>> enable-method = "psci";
>> next-level-cache = <&l2>;
>> };
>> @@ -308,6 +314,43 @@
>> interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
>> };
>> + thermal-zones {
>> + soc_thermal: soc-thermal {
>> + polling-delay-passive = <20>; /* milliseconds */
>> + polling-delay = <1000>; /* milliseconds */
>> + sustainable-power = <1000>; /* milliwatts */
>> +
>> + thermal-sensors = <&tsadc 0>;
>> +
>> + trips {
>> + threshold: trip-point0 {
>> + temperature = <70000>; /* millicelsius */
>> + hysteresis = <2000>; /* millicelsius */
>> + type = "passive";
>> + };
>> + target: trip-point1 {
>> + temperature = <85000>; /* millicelsius */
>> + hysteresis = <2000>; /* millicelsius */
>> + type = "passive";
>> + };
>> + soc_crit: soc-crit {
>> + temperature = <95000>; /* millicelsius */
>> + hysteresis = <2000>; /* millicelsius */
>
> The document had already described, maybe we should remove the
> millicelsius/milliseconds/milliwatts here.
It is ok for me.
>> + type = "critical";
>> + };
>> + };
>> +
>> + cooling-maps {
>> + map0 {
>> + trip = <&target>;
>> + cooling-device = <&cpu0 THERMAL_NO_LIMIT
>> THERMAL_NO_LIMIT>;
>> + contribution = <4096>;
>> + };
>> + };
>> + };
>> +
>> + };
>> +
>> tsadc: tsadc@ff250000 {
>> compatible = "rockchip,rk3328-tsadc";
>> reg = <0x0 0xff250000 0x0 0x100>;
>
>
>
>
next prev parent reply other threads:[~2017-08-11 9:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 8:06 [PATCH v2 0/5] thermal: rockchip: add tsadc support in thermal driver and IPA thermal control for rk3328 in dts Rocky Hao
2017-08-04 8:06 ` [PATCH v2 1/5] dt-bindings: rockchip-thermal: Support the RK3328 SoC compatible Rocky Hao
2017-08-10 17:49 ` Rob Herring
2017-08-11 1:08 ` rocky.hao
2017-08-04 8:06 ` [PATCH v2 2/5] thermal: rockchip: Support the RK3328 SOC in thermal driver Rocky Hao
2017-08-04 8:06 ` [PATCH v2 3/5] arm64: dts: rockchip: add tsadc node for rk3328 SoC Rocky Hao
2017-08-11 6:38 ` Caesar Wang
2017-08-11 9:45 ` rocky.hao
2017-08-11 9:47 ` Heiko Stuebner
2017-08-11 15:18 ` Heiko Stuebner
2017-08-04 8:06 ` [PATCH v2 4/5] arm64: dts: rockchip: add thermal nodes " Rocky Hao
2017-08-11 6:44 ` Caesar Wang
2017-08-11 9:46 ` rocky.hao [this message]
2017-08-11 9:48 ` Heiko Stuebner
2017-08-11 15:19 ` Heiko Stuebner
2017-08-04 8:09 ` [PATCH v2 5/5] arm64: dts: rockchip: Enable tsadc module on RK3328 eavluation board Rocky Hao
2017-08-11 15:19 ` Heiko Stuebner
2017-08-11 4:51 ` [PATCH v2 0/5] thermal: rockchip: add tsadc support in thermal driver and IPA thermal control for rk3328 in dts Zhang Rui
2017-08-11 6:22 ` rocky.hao
2017-08-11 6:27 ` Heiko Stuebner
2017-08-11 8:01 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0c7ab33-1b7b-8b9d-fd20-aa84001014cc@rock-chips.com \
--to=rocky.hao@rock-chips.com \
--cc=catalin.marinas@arm.com \
--cc=cl@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=jay.xu@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=shawn.lin@rock-chips.com \
--cc=will.deacon@arm.com \
--cc=william.wu@rock-chips.com \
--cc=wxt@rock-chips.com \
--cc=xxx@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®