From: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
To: Stephen Boyd <sboyd@kernel.org>,
agross@kernel.org, david.brown@linaro.org,
gregkh@linuxfoundation.org
Cc: jslaby@suse.com, keescook@chromium.org, anton@enomsg.org,
ccross@android.com, tony.luck@intel.com,
linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, khasim.mohammed@linaro.org,
agsumit@qti.qualcomm.com
Subject: Re: [PATCH] tty: serial: msm_serial: Fix XON/XOFF
Date: Mon, 20 May 2019 16:58:54 +0200 [thread overview]
Message-ID: <f0c89b84-7c3d-596d-06e1-cb5172e62970@linaro.org> (raw)
In-Reply-To: <254704a2-ee20-30cd-8362-6e1bd23ec090@linaro.org>
On 5/20/19 16:56, Jorge Ramirez wrote:
> On 5/20/19 16:51, Stephen Boyd wrote:
>> Quoting Jorge Ramirez-Ortiz (2019-05-20 03:34:35)
>>> When the tty layer requests the uart to throttle, the current code
>>> executing in msm_serial will trigger "Bad mode in Error Handler" and
>>> generate an invalid stack frame in pstore before rebooting (that is if
>>> pstore is indeed configured: otherwise the user shall just notice a
>>> reboot with no further information dumped to the console).
>>>
>>> This patch replaces the PIO byte accessor with the word accessor
>>> already used in PIO mode.
>>
>> Because the hardware only accepts word based accessors and fails
>> otherwise? I can believe that.
>>
>> I wonder if the earlier UART hardware this driver used to support (i.e.
>> pre-DM) would accept byte access to the registers. It's possible, but we
>> don't really care because those boards aren't supported.
>
> ok.
>
> also the PIO path uses iowrite32_rep to write a number of bytes (from 1
> to 4) so I think it is also appropriate to use it for XON/XOFF.
>
>>
>>>
>>> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
>>> ---
>>
>> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>>
>>> drivers/tty/serial/msm_serial.c | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
>>> index 109096033bb1..23833ad952ba 100644
>>> --- a/drivers/tty/serial/msm_serial.c
>>> +++ b/drivers/tty/serial/msm_serial.c
>>> @@ -869,10 +870,12 @@ static void msm_handle_tx(struct uart_port *port)
>>> else
>>> tf = port->membase + UART_TF;
>>>
>>> + buf[0] = port->x_char;
>>> +
>>> if (msm_port->is_uartdm)
>>> msm_reset_dm_count(port, 1);
>>>
>>> - iowrite8_rep(tf, &port->x_char, 1);
>>> + iowrite32_rep(tf, buf, 1);
>>
>> I suppose it's OK to write some extra zeroes here?
>>
>>
>
> yeah, semantically confusing msm_reset_dm_count is what really matters:
> it tells the hardware to only take n bytes (in this case only one) so
> the others will be ignored
um after I said this, maybe iowrite32_rep should only be applied to
uartdm ... what do you think?
>
>
next prev parent reply other threads:[~2019-05-20 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 10:34 Jorge Ramirez-Ortiz
2019-05-20 14:51 ` Stephen Boyd
2019-05-20 14:56 ` Jorge Ramirez
2019-05-20 14:58 ` Jorge Ramirez [this message]
2019-05-20 15:03 ` Stephen Boyd
2019-05-20 15:07 ` Jorge Ramirez
2019-05-20 15:11 ` Bjorn Andersson
2019-05-20 15:12 ` Bjorn Andersson
2019-05-20 15:20 ` Jorge Ramirez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0c89b84-7c3d-596d-06e1-cb5172e62970@linaro.org \
--to=jorge.ramirez-ortiz@linaro.org \
--cc=agross@kernel.org \
--cc=agsumit@qti.qualcomm.com \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=david.brown@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=keescook@chromium.org \
--cc=khasim.mohammed@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®