From: <Codrin.Ciubotariu@microchip.com>
To: <Claudiu.Beznea@microchip.com>, <lee.jones@linaro.org>,
<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>, <romain.izard.pro@gmail.com>
Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] mfd: atmel-flexcom: use resume_noirq
Date: Fri, 9 Jul 2021 09:09:10 +0000 [thread overview]
Message-ID: <f0ca6431-8143-9e47-9f7f-d1d14dbd5fb7@microchip.com> (raw)
In-Reply-To: <20210705113104.579535-3-claudiu.beznea@microchip.com>
On 05.07.2021 14:31, Claudiu Beznea wrote:
> Flexcom IP embeds 3 other IPs: usart, i2c, spi and selects the operation
> mode (usart, i2c, spi) via mode register (FLEX_MR). On i2c bus there might
> be connected critical devices (like PMIC) which on suspend/resume should
> be suspended/resumed at the end/beginning. i2c uses
> .suspend_noirq/.resume_noirq for this kind of purposes. Align flexcom
> to use .resume_noirq as it should be resumed before the embedded IPs.
> Otherwise the embedded devices might behave badly.
>
> Fixes: 7fdec11015c3 ("atmel_flexcom: Support resuming after a chip reset")
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Tested-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
next prev parent reply other threads:[~2021-07-09 9:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 11:31 [PATCH 0/2] mfd: atmel-flexcom: add a fix and code cosmetics Claudiu Beznea
2021-07-05 11:31 ` [PATCH 1/2] mfd: atmel-flexcom: remove #ifdef CONFIG_PM_SLEEP Claudiu Beznea
2021-07-09 9:11 ` Nicolas Ferre
2021-07-05 11:31 ` [PATCH 2/2] mfd: atmel-flexcom: use resume_noirq Claudiu Beznea
2021-07-09 9:09 ` Codrin.Ciubotariu [this message]
2021-07-09 9:12 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0ca6431-8143-9e47-9f7f-d1d14dbd5fb7@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=romain.izard.pro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®