From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966354AbcHBNcN (ORCPT ); Tue, 2 Aug 2016 09:32:13 -0400 Received: from smtp-proxy004.phy.lolipop.jp ([157.7.104.45]:36819 "EHLO smtp-proxy004.phy.lolipop.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966073AbcHBNaq (ORCPT ); Tue, 2 Aug 2016 09:30:46 -0400 Subject: Re: [PATCH 1170/1285] Replace numeric parameter like 0444 with macro To: Baole Ni , clemens@ladisch.de, perex@perex.cz, tiwai@suse.com, serge@hallyn.com, davem@davemloft.net, kadlec@blackhole.kfki.hu, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com References: <20160802122252.28150-1-baolex.ni@intel.com> Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, aryabinin@virtuozzo.com From: Takashi Sakamoto Message-ID: Date: Tue, 2 Aug 2016 22:30:44 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160802122252.28150-1-baolex.ni@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Aug 2 2016 21:22, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni Reviewed-by: Takashi Sakamoto > --- > sound/firewire/fireworks/fireworks.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c > index 71a0613..3390b4e 100644 > --- a/sound/firewire/fireworks/fireworks.c > +++ b/sound/firewire/fireworks/fireworks.c > @@ -27,16 +27,16 @@ static bool enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP; > unsigned int snd_efw_resp_buf_size = 1024; > bool snd_efw_resp_buf_debug = false; > > -module_param_array(index, int, NULL, 0444); > +module_param_array(index, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(index, "card index"); > -module_param_array(id, charp, NULL, 0444); > +module_param_array(id, charp, NULL, S_IRUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(id, "ID string"); > -module_param_array(enable, bool, NULL, 0444); > +module_param_array(enable, bool, NULL, S_IRUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(enable, "enable Fireworks sound card"); > -module_param_named(resp_buf_size, snd_efw_resp_buf_size, uint, 0444); > +module_param_named(resp_buf_size, snd_efw_resp_buf_size, uint, S_IRUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(resp_buf_size, > "response buffer size (max 4096, default 1024)"); > -module_param_named(resp_buf_debug, snd_efw_resp_buf_debug, bool, 0444); > +module_param_named(resp_buf_debug, snd_efw_resp_buf_debug, bool, S_IRUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(resp_buf_debug, "store all responses to buffer"); > > static DEFINE_MUTEX(devices_mutex); >