From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 167FF3D3306 for ; Mon, 20 Jul 2026 09:12:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784538752; cv=none; b=n64g23zG+dFYmZ3VUysyQmAESkQrIb8lxK2yzPiQhppgf57ySjREbc0o7xAifPabwMzWKu9lpqu0xHfNjXfEFxzb9YywkRmp2h/7v3IT0uTCvYfOcPFSO6Clu5uzv5bpiJnS5dIdIz9a98SRH30ZFEAZPCkoo9gVXm7uqVlGEOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784538752; c=relaxed/simple; bh=+KroKQ504uZlS0P7BdvijA4kbRAC47SmmveENz3cvL8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YO3ivJlyU/c6adZStUBNMsM/h5ofDan8/rXMnERzCozixIjojiR/ZfxitTTObFwLqIsRRliL8bGDbsE88RSMS9uuRMF1PObJeb2DDczCWQNHAPAAlzfZZrMHNaJ/f5nFmQOdS6Czh4hiDbBzh0KSBpFA/nW8VSlGDvPbAkup10A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N4sBfy4K; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AQh8kg/i; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N4sBfy4K"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AQh8kg/i" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66K97dYN1653624 for ; Mon, 20 Jul 2026 09:12:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pM3cA2IbXGthHBfz+fn33Io69DEDbJaIw/yDmpyN6P8=; b=N4sBfy4KFRoVQpab PLftOj5LvgIVJl/NO2VY/eLFN8dQD6mTlv63cXrPfSeI/wrAcmhDY4RUB72iWEx/ Kyhb7+XrQ3GMs3sF3p2VOXkcgw0j3KcercuzZy9S2dYBgM+wH+JjbxcoIoDQzrhl DearleLcM2rc3rj+GOrlA8cR13y6Qi561AC7fZ3xrJzH05xOa97nCB0q+QQTfYva vFGEYc6pIRwuI5W80vzCTDuk1rR9CtQLUkyTn1fg+7pLuJvEPBhnYdlWDpmH3fBd GU+lK+QQl+lV/U7mg5VcPYg4aFScrsYgpilUBJRRmgxa5wkb3OI1oeBrBwHkRGgs Aw9BMg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhgs500m5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 09:12:29 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e661ce1dcso186942885a.0 for ; Mon, 20 Jul 2026 02:12:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784538748; x=1785143548; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pM3cA2IbXGthHBfz+fn33Io69DEDbJaIw/yDmpyN6P8=; b=AQh8kg/iV1JuoN27tAJ/hDuey/h8m2sA0KiJO3k0Neje+2vmtL9BTeamwNn4I/mmKj ywLj0B4Fu25N6Fk0qor0QKHU7E98rCUdpI0XXt8bBvnIOye0D4nkaffduriSpoGQWq/K 8vZAP3Gn5LDKr9xlWy5FmzWM35ZuFgJYE4bFdzxLeXY7r5M/X1QMzCdmjWP41YRvD95F vaObyACvZKWe0rB6v9i99NmtN3OWOCN47WPg0tJcp0/xR3nz7it7Vm7jLjOQukW4BfTW 7m6mP1mBVlChamM7w6lrw+k989ODd3FtgBzKDTtmph14plj5cuxmVHbojjsiVmtFcPwl g+Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784538748; x=1785143548; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pM3cA2IbXGthHBfz+fn33Io69DEDbJaIw/yDmpyN6P8=; b=XpDcTiEPrvnXituOZc46N4JVWcS7r/QTHdECQljnZqtIReT2fnkU7q6RY8PhhcXl9x ECm0lusSh7RHux6yIDee+muE2QITdqsYIm0sNEmauXr3A+SmeLh7xmQQEe/eHgTKVLIY jgOTX+noOI6WMPZN9rf9exi/MOTOqawtjybeaGBvytRGiRXAEzBOUdQHjxRCIkhSqr2X YGgHHeO7BAkbl1rnpf5MN0xhi3yd6Y1DV6P2vK9RnuZCfrYRjlOMjNnOxjOz/GeZgS+6 LH9g9ZZXk9G6NYQDg7+FerXWkM5bAu628uvoW9+/g1G4YRRkMIgZRyErj6E/AV8f/l1R 5Alw== X-Forwarded-Encrypted: i=1; AHgh+RrJK6uFbKvwckKKB74rce+BUAq+jnOPJDkfFLlvnWgN9bF9W2SqgCvisUv3Oiu4PmftZByHCgXVaj8HSOc=@vger.kernel.org X-Gm-Message-State: AOJu0YzSVWDer76QrPmwDGOsxDnvK1YeOGaqcyJxMbytYAr9pj20tZ5K rzdeJiC9iOQdXMPHRVtJhbQoUtJkaggco12iH7Tjhj0RNn0mzkqoNLIUVSC8U0vS/QoadeJ4pny bmBA/g5jnrFGPf2r+EoZWjBRmV8n+eu4bwa74NvhdlIz9k5V1SMxE1dp6Ta9DBe/fRS0= X-Gm-Gg: AfdE7cl6s80/UISeQp4A6rfg2Zmq07Nh9Xi6Uqy50kW5MmIzQj7yFQJT0EogamZsPy8 7dL0WXEbFMTUxNvpf1cW89U9kqpJ9DpHNiy8wE2HXBR6lJtvz6zgW+fXQJBZ0PmtgPoIf4rHfSu UE8BxlQnO+OafJm5wkyZzaFwKmSfDrxAf78vUIYWncAFwujh2YNSU6rp9U0FnlHbyci2PnjsFAy 17v7+MxxZFu9puf+xyJ/LbgRtyFd/EWThDGUG6FspqpY4Q8jCb4ZcMbk37luyS/pDq0LlWlRIFL /LRmQ7AE9FbfPyjQZTus+FV8/piKJj24UHL1Y3VBDFBVXVMxaNEQQSywvBQvcmH4hSW0dbUK7/4 axpC5Yd8ExU6Wuo6jGFGwmoF+ X-Received: by 2002:a05:620a:d95:b0:920:798b:e290 with SMTP id af79cd13be357-930b437ba28mr1153247785a.7.1784538748109; Mon, 20 Jul 2026 02:12:28 -0700 (PDT) X-Received: by 2002:a05:620a:d95:b0:920:798b:e290 with SMTP id af79cd13be357-930b437ba28mr1153246585a.7.1784538747757; Mon, 20 Jul 2026 02:12:27 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c19457d6f0fsm388845666b.36.2026.07.20.02.12.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2026 02:12:26 -0700 (PDT) Message-ID: Date: Mon, 20 Jul 2026 11:12:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] media: qcom: camss: Report hardware version via media controller To: Loic Poulain , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260717-camss-version-v1-0-7ed71fea95e8@oss.qualcomm.com> <20260717-camss-version-v1-4-7ed71fea95e8@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260717-camss-version-v1-4-7ed71fea95e8@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDEwMiBTYWx0ZWRfX9MIO6AACOIQk gRyRoPK6FxOigAzrRr0rYWndTq5fODUQTvmnPFZJpCuA2EaOROQq6vI+A8MNmJWUUrpatL6caup WQbdDGrXGw9qfif2KnFK3JvNUFZBjjY= X-Proofpoint-GUID: nYSE0DyOfCnue4TK4vbtPdPyP2XZYk6I X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDEwMiBTYWx0ZWRfX+LGHQfSfNakQ j6V+o5KoFkLuC/YvAPpxXvdJO+83S++TCMxzqGiM3iKdmk8XiQblC5sP0VP36PHB1Fd/4fERG2d CVkvtr8h+rghUQuej122YOxUO07l+vGgIh2TzpoX4QEYekKJdztPWzkgdiAWbzvpxbDc4Ts9ADE hvdZuT9oldWskWlaQxbIfRq5OslVQ6mB958bPyIe5X2UHKA9/8s8GHsZhPfrC0GurO8xaikTii9 MptPgbXLOA0LwmGeMzuWu8MTFvHVIoIcgiWCwPO7uH72p0MlFm13D2jVjzMiXrSfw12VN05A8xU uEymGeDrO2yYbc0lfvKW/j+Fh4JKMZ0a33zfpYlpkq6scdWVjFXZ7jiVeKF88siss8QhmyDRPRO WomfVWzFJdMIuv67OM0J3fdtyz7ggYNO1SkImYR6TiOaU4HHCQqkhbz6jHm2oUJFAxWWr/oNpDK iih3XpFJb38DG58sqBQ== X-Authority-Analysis: v=2.4 cv=CpiPtH4D c=1 sm=1 tr=0 ts=6a5de67d cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=uMUtGptxAjs8TZNG6GYA:9 a=QEXdDO2ut3YA:10 a=ZXulRonScM0A:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: nYSE0DyOfCnue4TK4vbtPdPyP2XZYk6I X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_01,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200102 On 7/17/26 4:20 PM, Loic Poulain wrote: > Populate media_dev.hw_revision with the top-level CAMSS hardware version > so that user space can query the exact hardware variant through the media > controller (e.g. via media-ctl or MEDIA_IOC_DEVICE_INFO). This can help > identify the platform variant and adapt behaviour accordingly, for example > allowing libcamera to apply quirks or enable features that cannot be > discovered through standard V4L2 or media-controller APIs. [...] > +static void camss_read_version(struct camss *camss) > +{ > + u32 hw_version; > + > + if (!camss->top_base || !camss->res->pm_clks[0]) > + return; > + > + if (pm_runtime_resume_and_get(camss->dev)) > + return; > + > + hw_version = readl_relaxed(camss->top_base + CAMSS_HW_VERSION); > + > + pm_runtime_put_sync(camss->dev); I think non-sync is fine here TOP+0x0 seems to hold on TITAN, MSM8916 and MSM8996 Reviewed-by: Konrad Dybcio Konrad