From: Neil Armstrong <narmstrong@baylibre.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>, linux-gpio@vger.kernel.org
Cc: linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
cphealy@gmail.com
Subject: Re: [PATCH 00/14] pinctrl-sx150x: Various bug-fixes and code simplifications
Date: Wed, 2 Nov 2016 14:33:42 +0100 [thread overview]
Message-ID: <f0cdd71c-3036-56f8-74a4-ebf20cde75b4@baylibre.com> (raw)
In-Reply-To: <9bc0e603-b861-85d8-914f-bd4b6e8a8020@baylibre.com>
On 11/02/2016 12:01 PM, Neil Armstrong wrote:
> On 11/01/2016 04:57 PM, Andrey Smirnov wrote:
>> Linus, Neil:
>>
>> I've had some help and got my hardware setup modified to enable IRQ
>> functionality testing, so ended up looking at the code of SX150x more
>> resulting in some code improvements (hopefully) and bugfixes.
>>
>> There are many small changes each of which is probably better
>> described by corresponding commit's message, however the most
>> porminenet changes of the whole patchset are the switch to regmap API
>> (patches ## 7,8) and reduction of locking (patch # 9)
>>
>> Please let me know what you think.
>>
>> Thanks,
>> Andrey
>>
>> Andrey Smirnov (14):
>> pinctrl-sx150x: Rely on of_modalias_node for OF matching
>> pinctrl-sx150x: Add SX1503 specific data
>> pinctrl-sx150x: Replace magic number in sx150x_init_hw
>> pinctrl-sx150x: Fix incorrect constant in sx150x_init_hw
>> pinctrl-sx150x: Move some code out of sx150x_init_hw
>> pinctrl-sx150x: Improve sx150x_init_misc for SX1504/5/6
>> pinctrl-sx150x: Convert driver to use regmap API
>> pinctrl-sx150x: Replace sx150x_*_cfg by means of regmap API
>> pinctrl-sx150x: Remove excessive locking
>> pinctrl-sx150x: Improve oscio GPIO functions
>> pinctrl-sx150x: Simplify interrupt handler
>> pinctrl-sx150x: Use handle_bad_irq instead of handle_edge_irq
>> pinctrl-sx150x: Remove magic numbers from sx150x_irq_set_type
>> pinctrl-sx150x: Remove magic numbers from sx150x_reset
>>
>> drivers/pinctrl/pinctrl-sx150x.c | 753 +++++++++++++++++++++------------------
>> 1 file changed, 416 insertions(+), 337 deletions(-)
>>
>
> Hi Andrey,
>
> This is good, you went faster than me !
>
> Small point, could you add Kconfig dependency on REGMAP ?
>
> I will try out this patchset and hopefully get you a Tested-by in the next few days.
>
> Neil
>
Great, Successfully worked on 4.9-rc2 on my BeagleBone black installation with a SX1509.
I got some rising and falling interrupts using gpio-event-mon.
Small NIT: please add the sx1503 entry in the Kconfig desc and in the pinctrl-sx150x.txt bindings.
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
With the Kconfig and bindings changes :
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Thanks,
Neil
next prev parent reply other threads:[~2016-11-02 13:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 15:57 Andrey Smirnov
2016-11-01 15:57 ` [PATCH 01/14] pinctrl-sx150x: Rely on of_modalias_node for OF matching Andrey Smirnov
2016-11-04 12:28 ` Linus Walleij
2016-11-04 20:09 ` Andrey Smirnov
2016-11-04 21:29 ` Linus Walleij
2016-11-01 15:57 ` [PATCH 02/14] pinctrl-sx150x: Add SX1503 specific data Andrey Smirnov
2016-11-01 15:57 ` [PATCH 03/14] pinctrl-sx150x: Replace magic number in sx150x_init_hw Andrey Smirnov
2016-11-01 15:57 ` [PATCH 04/14] pinctrl-sx150x: Fix incorrect constant " Andrey Smirnov
2016-11-01 15:57 ` [PATCH 05/14] pinctrl-sx150x: Move some code out of sx150x_init_hw Andrey Smirnov
2016-11-01 15:57 ` [PATCH 06/14] pinctrl-sx150x: Improve sx150x_init_misc for SX1504/5/6 Andrey Smirnov
2016-11-01 15:57 ` [PATCH 07/14] pinctrl-sx150x: Convert driver to use regmap API Andrey Smirnov
2016-11-01 15:57 ` [PATCH 08/14] pinctrl-sx150x: Replace sx150x_*_cfg by means of " Andrey Smirnov
2016-11-01 15:57 ` [PATCH 09/14] pinctrl-sx150x: Remove excessive locking Andrey Smirnov
2016-11-01 15:57 ` [PATCH 10/14] pinctrl-sx150x: Improve oscio GPIO functions Andrey Smirnov
2016-11-01 15:57 ` [PATCH 11/14] pinctrl-sx150x: Simplify interrupt handler Andrey Smirnov
2016-11-01 15:57 ` [PATCH 12/14] pinctrl-sx150x: Use handle_bad_irq instead of handle_edge_irq Andrey Smirnov
2016-11-01 15:57 ` [PATCH 13/14] pinctrl-sx150x: Remove magic numbers from sx150x_irq_set_type Andrey Smirnov
2016-11-01 15:57 ` [PATCH 14/14] pinctrl-sx150x: Remove magic numbers from sx150x_reset Andrey Smirnov
2016-11-02 11:01 ` [PATCH 00/14] pinctrl-sx150x: Various bug-fixes and code simplifications Neil Armstrong
2016-11-02 13:33 ` Neil Armstrong [this message]
2016-11-03 22:22 ` Andrey Smirnov
2016-11-04 12:17 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0cdd71c-3036-56f8-74a4-ebf20cde75b4@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=andrew.smirnov@gmail.com \
--cc=cphealy@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®