From: Markus Elfring <Markus.Elfring@web.de>
To: Chuhong Yuan <hslester96@gmail.com>, linux-clk@vger.kernel.org
Cc: Akshu Agrawal <Akshu.Agrawal@amd.com>,
Daniel Kurtz <djkurtz@chromium.org>,
Michael Turquette <mturquette@baylibre.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Stephen Boyd <sboyd@kernel.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: clk-st: Add missed return value checks in st_clk_probe()
Date: Wed, 3 Jun 2020 19:30:46 +0200 [thread overview]
Message-ID: <f0d21bd6-6db7-d643-b662-6ca26efd28ba@web.de> (raw)
> st_clk_probe() has not check for clk_hw_register_mux(), clk_hw_register_gate()
> and devm_clk_hw_register_clkdev().
> Add the missed checks and return devm_clk_hw_register_clkdev()'s return value
> to check errors.
How do you think about another wording variant?
Return values were not checked after calls of the following functions.
- clk_hw_register_mux
- clk_hw_register_gate
- devm_clk_hw_register_clkdev
* Thus add error detection and the corresponding exception handling.
* Return the value from the function call “devm_clk_hw_register_clkdev”
at the end of this function implementation.
Regards,
Markus
reply other threads:[~2020-06-03 17:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0d21bd6-6db7-d643-b662-6ca26efd28ba@web.de \
--to=markus.elfring@web.de \
--cc=Akshu.Agrawal@amd.com \
--cc=djkurtz@chromium.org \
--cc=hslester96@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rafael.j.wysocki@intel.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®