From: Pei Xiao <xiaopei01@kylinos.cn>
To: Guenter Roeck <linux@roeck-us.net>,
xiaopeitux@foxmail.com, cryolitia@uniontech.com,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] hwmon: (gpd-fan): drop global driver data and use per-device allocation
Date: Wed, 10 Jun 2026 09:30:09 +0800 [thread overview]
Message-ID: <f0d42e9e-74f7-4b94-968c-a5a22e28f2d2@kylinos.cn> (raw)
In-Reply-To: <e10eb414-082e-4747-8083-77b1a3b8c934@roeck-us.net>
在 2026/6/9 21:04, Guenter Roeck 写道:
> On 6/7/26 18:40, xiaopeitux@foxmail.com wrote:
>> From: Pei Xiao <xiaopei01@kylinos.cn>
>>
>> replace the global state gpd_driver_priv with per-device private data
>> (struct gpd_fan_data) allocated in probe. This allows the driver to
>> support multiple instances in the future and aligns with kernel best
>> practices.
>>
>> No functional change intended.
>> ---
>
> I got:
>
> Commit
>
> beb0e2d1add1e2 ("hwmon: (gpd-fan): drop global driver data and use
> per-device allocation")
>
> is missing a Signed-off-by from its author
>
hi Guenter,
Sorry for wasting your time.
I made a mistake. I thought the content between the
first |---| delimiter and the second delimiter
was invisible to |git am|, and the content between the second and third |
---| delimiters was visible,
so I lost the |sob|. I will resend version 4 with my |sob|.
Pei
> Since it is the first patch of the series I had to drop the entire
> series.
> Please resend with proper tags.
>
> Guenter
next prev parent reply other threads:[~2026-06-10 1:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1780880972.git.xiaopei01@kylinos.cn>
2026-06-08 1:40 ` xiaopeitux
2026-06-09 13:04 ` Guenter Roeck
2026-06-10 1:30 ` Pei Xiao [this message]
2026-06-09 15:46 ` Cryolitia PukNgae
2026-06-10 1:36 ` Pei Xiao
2026-06-08 1:40 ` [PATCH v3 2/4] hwmon: (gpd-fan): Initialize EC before registering hwmon device xiaopeitux
2026-06-08 1:40 ` [PATCH v3 3/4] hwmon: (gpd-fan): upgrade log level from warn to err for platform device creation failure xiaopeitux
2026-06-08 1:40 ` [PATCH v3 4/4] hwmon: (gpd-fan): fix race condition between device removal and sysfs access xiaopeitux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0d42e9e-74f7-4b94-968c-a5a22e28f2d2@kylinos.cn \
--to=xiaopei01@kylinos.cn \
--cc=cryolitia@uniontech.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=xiaopeitux@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®