Re: [PATCH v2 1/2] dt-bindings: power: Add binding for MediaTek MT6735 power controller

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 02/03/23 13:27, Yassine Oudjana ha scritto:
> From: Yassine Oudjana <y.oudjana@protonmail.com>
> 
> Add DT binding for MediaTek MT6735 SCPSYS power controller.
> 
> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> ---
>   .../bindings/power/mediatek,power-controller.yaml  |  2 ++
>   .../devicetree/bindings/soc/mediatek/scpsys.txt    |  1 +
>   include/dt-bindings/power/mt6735-power.h           | 14 ++++++++++++++

I know many others don't follow the right binding filenames and I am sure
you named it like that looking at the other ones, but please rename this
to mediatek,mt6735-power.h and resend.

The rest looks good.

>   3 files changed, 17 insertions(+)
>   create mode 100644 include/dt-bindings/power/mt6735-power.h
> 
> diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
> index c9acef80f452..710db61cab53 100644
> --- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
> +++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
> @@ -23,6 +23,7 @@ properties:
>   
>     compatible:
>       enum:
> +      - mediatek,mt6735-power-controller
>         - mediatek,mt6795-power-controller
>         - mediatek,mt8167-power-controller
>         - mediatek,mt8173-power-controller
> @@ -81,6 +82,7 @@ $defs:
>         reg:
>           description: |
>             Power domain index. Valid values are defined in:
> +              "include/dt-bindings/power/mt6735-power.h" - for MT6735 type power domain.

P.S.: Don't forget to update this addition after the rename :-)

After - and only after - renaming,

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>