From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36B59312814 for ; Wed, 3 Dec 2025 20:23:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764793396; cv=none; b=S4tgYQiSBw3UC8mfQLYUc6d4t+hbt56i+0YAx17KDQ0BOuMxPode/1xZ3U7gmRLnP5vZUxZBQ+WK+/DOXDy0zvQ5S6c9nzf4TB0BlzNHWT42RAmvd+JBCGvj9/cgyVBU32VNA7IFwzVG/ZZei/PqE4qeSco9ixjBcxU33hNt8z0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764793396; c=relaxed/simple; bh=io2SxxGF8RuQGVJttfCZrQUaiyFjgniVx2tyjXRcN1w=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=LjnY14+GkKgMIwVnn7GDrQ7FrJzqdJ/XXRfs+HfcpCylcoWPdoc7nU7Tm9u3PyoVPKXargLuwTIDa0RR8S+/GRlU2v6691h3TMG2eZiSjohvGitH0/X87KTZwdvqxB7V587Xs2/FNuSewgFeHgATe0ABJX/+xpQGF0cPGhjg6lY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nLWE2uSs; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nLWE2uSs" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-477b91680f8so1855965e9.0 for ; Wed, 03 Dec 2025 12:23:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764793391; x=1765398191; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=la5DY+nye5Y4WsEMXBxzYTG6S0M/hvXAkvJ3L0NdBQ8=; b=nLWE2uSshFXL6ovI9cd5G4crvnsigqxpDExkT7wiPxgAZpAh4whP2+KhyTGX0S0UbA k+5So+F1qIIUOMRfcJwdTjjwTFzY2d2D9HcV0s11Kew96ofwx/E1cipODsstbQrHg1xm 3Wbk7cwiRThF92rLUUcWG0zk4BDqraTBQwVttBQ3jEGluu9SNIzGdWg9Gs/QzL6Lbspd q1sqcj/mnbeTw/579/WxELAmiWRn8dzdRL37BKuy5OeA/IWxwxG40YgrIfKGHEeXWDo5 +gqsCt8CrWKyXjVsccg+kJSfqv2E6KiNVx+iwKVwHi88nA1BJoAw6RqaxH5VCIxCQp5A taIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764793391; x=1765398191; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=la5DY+nye5Y4WsEMXBxzYTG6S0M/hvXAkvJ3L0NdBQ8=; b=D86AbzfXRGj5vtydPeszcDD6KZqSeL42zVjtDt4FzU+Gnw5cjUpd5+OM1C5h+YuAra RtVldUvAZQDQz13od7FRfOl3HP4zmkUaM2WkhqNODXQNJFJLtfF+5rUWTZ26wt7jLU0M ipITjOhqvXDeT8CeyYLVo28q0/ahNlcNPF4RIcp+cqdjwFicUaFZZ5GUOP53MqVsIpyO d/6VtKUIsTbOOcHn0ALH6WgH2kmR+OSUvg+pdEc5+3n7g9OfSTOrSPilDaNffBQCKLxY BsfVhQXwxgyL2X8CsCHEvlygseUmRQE4OA3ZrLFv1qGpWIOv8LNSLW/0XNsh0S2YQ2uC BADg== X-Forwarded-Encrypted: i=1; AJvYcCWMkI8KgLDLyhdMH/qNPtyAv5A7zJv11sfvyXtbhIptKWwqH9fhazixyegjy1w5uv7O8pETqxbVgJvH+qE=@vger.kernel.org X-Gm-Message-State: AOJu0YypiIku6CbCOGrBo8/rJHqIM+V73jX+sO5wnqGcjxxMtJ+F2erM tinjOOf8hyCvlX3zuft74Z1Q8oZ5k7CXdS8mi2sca+jhFmbxnpIv9pM= X-Gm-Gg: ASbGnct6kk1uuiDMIQsBI3jRYP4dh3ndQ3kenJu9rzvI6JkOpQIcfudIF9ThdNHWd7y skujjC6cs57ZkIPA0LhJ/imW9W93cZVScSUHc7sWniyfV+UKj5/GYOVCmHEUU6hOtslCWkv0CiS 7+5WQjBZ3kIuhTH6sbpr680v0lFenkrkGe1Uw9te/C9+ZA00VU9Nb1YuzYL5blI7oW6WX/XLGs1 wySyUrUtZgYcgnm06C4PXc+PfHpp0J1UtsSkZGjCqWyvemUOUI2xLNDs0uuMKBcJEBrT8aTuITc 5tIlyinDDlpECTfb1tBNgcNxreWAiz4Tv07wyTZqzeXHYtlohqq8k8Z5Kbim1cLM9to5iLp+qc2 PGeqrz/GD9KoLsCeo2wIwc59qEi8iRbULk2J7lIj2R7sEUmqSj+nmWmq7IRrX7v6/neR7OY6bVj aUYA975t/1To2hfbO0z0s7rlMuC4hfTHnX8soK8J8rHEYZPNE/lXhwXCBNr4z/S1pYwDs= X-Google-Smtp-Source: AGHT+IEpGSW/EFraUJRRr3A4U1L8grZ6drN7sy7XuL6+qwvpsW1qlvzAiO5Upxd981TrT5V2Ub2FOw== X-Received: by 2002:a05:600c:4443:b0:477:9b35:3e36 with SMTP id 5b1f17b1804b1-4792aedfbf4mr38189915e9.2.1764793391265; Wed, 03 Dec 2025 12:23:11 -0800 (PST) Received: from ?IPV6:2a02:810b:f13:8500:3079:1d24:47d4:553a? ([2a02:810b:f13:8500:3079:1d24:47d4:553a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4792a7971c7sm68875275e9.2.2025.12.03.12.23.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Dec 2025 12:23:10 -0800 (PST) Message-ID: Date: Wed, 3 Dec 2025 21:23:12 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: rockchip: add SPDIF audio to Beelink A1 To: Robin Murphy , Christian Hewitt , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250828164300.3829488-1-christianshewitt@gmail.com> <66ae20b3-3316-4ec2-9c51-8414c053dc32@arm.com> Content-Language: en-US From: Alex Bee In-Reply-To: <66ae20b3-3316-4ec2-9c51-8414c053dc32@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Robin, Am 03.12.25 um 17:21 schrieb Robin Murphy: > [ Just noticed this... ] > > On 2025-08-28 5:43 pm, Christian Hewitt wrote: >> From: Alex Bee >> >> Add the required nodes to enable SPDIF audio output on >> the Beelink A1 set-top-box. > > But the A1 doesn't have S/PDIF? Only HDMI plus a 3.5mm jack connected > to the analog audio codec (and possibly the composite TV out) :/ > Yeah, sorry - this patch wasn't supposed to be submitted upstream. Regards, Alex > Thanks, > Robin. > >> Signed-off-by: Alex Bee >> Signed-off-by: Christian Hewitt >> --- >>   arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 23 ++++++++++++++++++++++ >>   1 file changed, 23 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts >> b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts >> index f7c4578865c5..b276a29bdd85 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts >> @@ -58,6 +58,24 @@ ir-receiver { >>           gpios = <&gpio2 RK_PA2 GPIO_ACTIVE_LOW>; >>           linux,rc-map-name = "rc-beelink-gs1"; >>       }; >> + >> +    spdif_sound: spdif-sound { >> +        compatible = "simple-audio-card"; >> +        simple-audio-card,name = "SPDIF"; >> + >> +        simple-audio-card,cpu { >> +            sound-dai = <&spdif>; >> +        }; >> + >> +        simple-audio-card,codec { >> +            sound-dai = <&spdif_dit>; >> +        }; >> +    }; >> + >> +    spdif_dit: spdif-dit { >> +        compatible = "linux,spdif-dit"; >> +        #sound-dai-cells = <0>; >> +    }; >>   }; >>     &analog_sound { >> @@ -325,6 +343,11 @@ &sdmmc { >>       status = "okay"; >>   }; >>   +&spdif { >> +    pinctrl-0 = <&spdifm0_tx>; >> +    status = "okay"; >> +}; >> + >>   &tsadc { >>       rockchip,hw-tshut-mode = <0>; >>       rockchip,hw-tshut-polarity = <0>;