From: Thorsten Leemhuis <linux@leemhuis.info>
To: SurajSonawane2415 <surajsonawane0215@gmail.com>
Cc: corbet@lwn.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] docs: Fix grammar and phrasing errors in reporting-issues.rst
Date: Fri, 16 Aug 2024 11:58:07 +0200 [thread overview]
Message-ID: <f0e080d3-1ca4-409e-a038-657f0105b41a@leemhuis.info> (raw)
In-Reply-To: <20240816093646.116091-1-surajsonawane0215@gmail.com>
On 16.08.24 11:36, SurajSonawane2415 wrote:
> Fix grammatical errors and improve phrasing in the `reporting-issues.rst`
> documentation file. These changes enhance readability and ensure the
> accuracy of the instructions provided.
>
> Signed-off-by: SurajSonawane2415 <surajsonawane0215@gmail.com>
> ---
> V2 -> V3: Re-added the fix for the line: "That's why you might be need to uninstall the".
> V1 -> V2: emoved the unwanted change to the line: "try search terms like".
Thx, description sounds good. Final verdict ist up to Jonathan. And
changelog is great as well (apart from the typo in "removed", but
things happen, so no worries :-D )
Sadly there is one more thing where I apparently was unclear earlier:
> @@ -472,7 +472,7 @@ before proceeding.
> Note, you might not be aware that your system is using one of these solutions:
> they often get set up silently when you install Nvidia's proprietary graphics
> driver, VirtualBox, or other software that requires a some support from a
> -module not part of the Linux kernel. That why your might need to uninstall the
> +module not part of the Linux kernel. That's why you might be need to uninstall the
> packages with such software to get rid of any 3rd party kernel module.
That last "the" makes the line too long, so it needs to move to the next
line. The diff thus should look like this in the end:
-module not part of the Linux kernel. That why your might need to uninstall the
+module not part of the Linux kernel. That's why you might be need to uninstall
+the packages with such software to get rid of any 3rd party kernel module.
But wait a moment: that additional "be" looks wrong to me. If you agree,
remove it and resend, then everything will be fine afaics. Sorry, I
should have noticed that earlier.
Ciao, Thorsten
prev parent reply other threads:[~2024-08-16 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 9:36 SurajSonawane2415
2024-08-16 9:58 ` Thorsten Leemhuis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0e080d3-1ca4-409e-a038-657f0105b41a@leemhuis.info \
--to=linux@leemhuis.info \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=surajsonawane0215@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®