From: Petr Pavlu <petr.pavlu@suse.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>,
Daniel Gomez <da.gomez@samsung.com>, Kees Cook <kees@kernel.org>,
linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH v1 0/3] module: Don't fail module loading when setting ro_after_init section RO failed
Date: Fri, 3 Jan 2025 17:13:32 +0100 [thread overview]
Message-ID: <f0e892c7-43cd-4310-9d60-1d6e839f5bb2@suse.com> (raw)
In-Reply-To: <cover.1733427536.git.christophe.leroy@csgroup.eu>
On 12/5/24 20:46, Christophe Leroy wrote:
> This series reworks module loading to avoid leaving the module in a
> stale state when protecting ro_after_init section fails.
>
> Once module init has succeded it is too late to cancel loading.
> If setting ro_after_init data section to read-only fails, all we can
> do is to inform the user through a warning. This is what patch 2 does.
>
> Then patch 3 tries to go a bit further by testing the ability to write
> protect ro-after-init section prior to initialising the module.
I've been holding off on applying this series to modules-next because
there was still some discussion on the previous RFC version [1], and
I wanted to give people more time to potentially comment.
Mike Rapoport also recently posted a series with a patch [2] that
proposes restoring of large pages after fragmentation. Should the last
patch here be then dropped?
[1] https://lore.kernel.org/linux-modules/737f952790c96a09ad5e51689918b97ef9b29174.1731148254.git.christophe.leroy@csgroup.eu/
[2] https://lore.kernel.org/linux-modules/20241227072825.1288491-4-rppt@kernel.org/
--
Thanks,
Petr
next prev parent reply other threads:[~2025-01-03 16:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 19:46 Christophe Leroy
2024-12-05 19:46 ` [PATCH v1 1/3] module: Split module_enable_rodata_ro() Christophe Leroy
2024-12-05 19:46 ` [PATCH v1 2/3] module: Don't fail module loading when setting ro_after_init section RO failed Christophe Leroy
2024-12-05 19:46 ` [PATCH v1 3/3] module: pre-test setting ro_after_init data read-only Christophe Leroy
2024-12-11 4:29 ` [PATCH v1 0/3] module: Don't fail module loading when setting ro_after_init section RO failed Luis Chamberlain
2025-01-03 16:13 ` Petr Pavlu [this message]
2025-01-04 7:39 ` Christophe Leroy
2025-01-06 14:01 ` Petr Pavlu
2025-01-07 0:13 ` Kees Cook
2025-01-07 13:00 ` Daniel Gomez
2025-01-08 19:17 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0e892c7-43cd-4310-9d60-1d6e839f5bb2@suse.com \
--to=petr.pavlu@suse.com \
--cc=christophe.leroy@csgroup.eu \
--cc=da.gomez@samsung.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=rppt@kernel.org \
--cc=samitolvanen@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®