From: Markus Elfring <Markus.Elfring@web.de>
To: Louis Chauvet <louis.chauvet@bootlin.com>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Brian Xu <brian.xu@amd.com>, Lizhi Hou <lizhi.hou@amd.com>,
Michal Simek <michal.simek@amd.com>,
Raj Kumar Rampelli <raj.kumar.rampelli@amd.com>,
Vinod Koul <vkoul@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: xilinx: xdma: Fixes possible threading issue
Date: Mon, 27 May 2024 20:32:05 +0200 [thread overview]
Message-ID: <f0eaf77b-eed9-4f8e-8009-983250fa56a8@web.de> (raw)
In-Reply-To: <20240527-xdma-fixes-v1-1-f31434b56842@bootlin.com>
> The current interrupt handler in xdma.c was using xdma->stop_request
> before locking the vchan lock.
1. Will an additional imperative wording become helpful here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc1#n94
2. How do you think about to use the summary phrase “Fix data synchronisation in xdma_channel_isr()”?
3. Will development interests grow for the usage of a statement like “guard(spin)(&xchan->vchan.lock);”?
https://elixir.bootlin.com/linux/v6.10-rc1/source/include/linux/cleanup.h#L124
Regards,
Markus
next prev parent reply other threads:[~2024-05-27 18:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 16:29 Louis Chauvet
2024-05-27 18:32 ` Markus Elfring [this message]
2024-06-07 8:34 ` Louis Chauvet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0eaf77b-eed9-4f8e-8009-983250fa56a8@web.de \
--to=markus.elfring@web.de \
--cc=brian.xu@amd.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.hou@amd.com \
--cc=louis.chauvet@bootlin.com \
--cc=michal.simek@amd.com \
--cc=raj.kumar.rampelli@amd.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®