From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13F81403AE1 for ; Mon, 29 Jun 2026 12:43:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782737022; cv=none; b=j52bk4MptrxwNjlTIxwIDl4r1CZg+sf0kdZNX6Q9WpYrGo+LwgSSjx/qjB/Ac0PrwSAKNQtTKXlaDpyBhF8t6d7bJrOpqWnYY8aO3SJa6yn9Kqfa2Ea/OPHuJ6hVt1P5TXAH77Ihy4nuYkchHBX58QFJp39mByZEjFwlScCv+hA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782737022; c=relaxed/simple; bh=iL8eQCnQSbG2ojygIK5P3cXtGszj1MWC/yVH3lFhswM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ue+xPKFxcEgsUmpydJbPlPv5XRpYcen8f87xvJ9BZKXdWncEKk1oUTsqGU5Z84RPBdulr9zfnWKRSG5kaTuWSydDiQY9cAR6mXgRkyo/orW618Rq5tq2pqvXzNTTzNR1pg7BBcSCWTN+q/YICRfbmOzCs6irUI/3dU68GqNddWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NMdpH6YD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZWBBhSBp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NMdpH6YD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZWBBhSBp" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65TATB642647650 for ; Mon, 29 Jun 2026 12:43:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CpHcwEms8mZxbI2w+Md5BrpKxIEKLFyT45Gg2vM0YiY=; b=NMdpH6YDeqCM6Ng2 6l+u1JT4xPqzvjoTIliP40I8uS1vyj+L87A0s/qye2JFugwtFubIXUyRV7TGDunu R6AT7ytIJgsoT9qLUDl4wVFliJkW4IuqsH8CbCK3KeaS2RCkVYPYUJb3E2XmVf/n n3hDCcBxNJlzKeVUAMJaWhtjvocMm4xmBllzsNmFZBHpLfh9MoNKpAQANg8pAcNm TXF0zOy0GX+9LwYTaSDruBciQSlEcjcnL39ePRYOwyzIFsHATrj9EfyXaS+7TQfj LXtLZZhSE0HawuL0/q6HT7LO9lTXKMaK7kYXAJnJbjWc2xRjybwKZ0RF9NkF8Rk6 8fCEwA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3kyjhacx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 12:43:40 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-37fcaf3fe72so1757625a91.3 for ; Mon, 29 Jun 2026 05:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782737019; x=1783341819; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CpHcwEms8mZxbI2w+Md5BrpKxIEKLFyT45Gg2vM0YiY=; b=ZWBBhSBpkN7U1a4i9A+0lyZi37P59NHUTaHRxPctYZd7M5PKOhhxHhsrbRHlyXSPaA 7g2pTDiUT2cMwStL6aFYlTt9xcXUfjFg6PZm5M5A08PV+ZQczYWLkl3msHBYC6pcA+I/ xeBlQHDX37KX/jltvdN/s6XCJWMH7mio4NbpE4Oszi90X2bmxyZ4jvTriu9et3RJXb4b dq/GtcOY/W4kwIz9Oee0eg1jZfqMkEWl+CoyAUIeO54TRy4aReXE6b9EAdkZXkK0FsQZ oVdtRw+Kfe0GzbER2JtWZG0NcZBAHeFE4T36yW1KOWu+n1fZmsWkmVbdQ0gNI3z7MrEv /aeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782737019; x=1783341819; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CpHcwEms8mZxbI2w+Md5BrpKxIEKLFyT45Gg2vM0YiY=; b=N/OamvOBA2ewQOTcYlGJZR4spOSctzlACWmHAPkX1EgEtE0sxmTX/Q1XsVeMl7RuUs HsP9kluxhSzErwxoM8WIYNZs83CSLN6oAZd3tP0zgE9gwBRV3elCOf14HtZPqr6pubwi m+QhGwxaxcFuNEUUyanGB5eEX2vBReXQi9uB7uDriKmNbhUdfSjNngPehRIctS7MFSkq zQhIQLTAz9OWG3qUu3TW4bF7kYrfaOu3kt8tU8wL8ldjHpFqUFtS/06BXcz/1tWm4Cl0 kRG6aIzvrx4pzcI/XxJO7IkhKQoPfLbxtxXWgbgqqJOLr7pHlhxCqP1jGUMEOiM6awp2 tzzA== X-Forwarded-Encrypted: i=1; AHgh+RplwDBADMy4e8pNOnEBJ5gpvR58AeJxH/PyCHJabDC9C18reEIqG7CUNLrKrTetgUswxNwV0/C/OgnaEPc=@vger.kernel.org X-Gm-Message-State: AOJu0YzEMVEXGApn3KucWo+PEII9Mw1LK+dQAt21aRwKTRK6S0gyP0gU YyEWwrOd7/x3rgMMbTOB5TLp3XX4nneFBHeAqCiFoc0j6SoXpexGfIa++CreGSnbUs2T7p0iwe5 VrrhiBJPwmskfFLe62lscT4pMO+lsv0OKanc90hMWEWSh4p2XmIHzv/e0lT8Xd/Ad7t4= X-Gm-Gg: AfdE7cnkGmER6MtCJyyyKNEdtxJe2iMj11TerTeL0IIVVIjnE57Q1/KYFsW/cdoeLY0 yhgCUlE7ifbxK3utwGeA2yupsih5usxGF1nwYudC0gMnjQhit4s562vhgkZtZ6F92ls4kRfPQSe HytCGNH27QeDR4cMf1doBDo7DkNWkZJlJA/XjoxtwTDAnv+plcfdL6gJ2HP+VnnAuMwi684sbq1 5DWRuXuU8amXmBA+ku8PwCAKoQBRHJ9NXQGRLGe9x3BffnN9dy/bnCtAzwOovvP38R6fqgKYOFG zKymKdsDbAf6+uvHjSBQ7lEOgObicn5rTSplGg+bIKS7T7PbquA5d93KQzrGRJSKpaMQ6Lv6hzW 6GWN4SDIQRXrxbR+4bADfCMGJ/rB7uZO8g0g+jueHCgTjpZYk9o2PHRXWITuVG9rWWtUx4y8wFE D0igpnRg== X-Received: by 2002:a17:90b:4ecd:b0:37f:9ce1:cdb0 with SMTP id 98e67ed59e1d1-37f9ce2229dmr7491051a91.30.1782737019090; Mon, 29 Jun 2026 05:43:39 -0700 (PDT) X-Received: by 2002:a17:90b:4ecd:b0:37f:9ce1:cdb0 with SMTP id 98e67ed59e1d1-37f9ce2229dmr7491002a91.30.1782737018606; Mon, 29 Jun 2026 05:43:38 -0700 (PDT) Received: from [10.133.33.246] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37eaff87f61sm5602580a91.17.2026.06.29.05.43.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 05:43:38 -0700 (PDT) Message-ID: Date: Mon, 29 Jun 2026 20:43:25 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/7] cpufreq: rcpufreq_dt: use vertical import style To: Guru Das Srinagesh , Miguel Ojeda , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Danilo Krummrich , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Andreas Hindborg , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Trevor Gross , Tamir Duberstein , Alexandre Courbot , =?UTF-8?Q?Onur_=C3=96zkan?= , Drew Fustini , Guo Ren , Fu Wei , Michal Wilczynski , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , "Rafael J. Wysocki" , Viresh Kumar , Jens Axboe , FUJITA Tomonori , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Airlie , Simona Vetter , driver-core@lists.linux.dev, linux-riscv@lists.infradead.org, linux-pwm@vger.kernel.org, linux-pm@vger.kernel.org, linux-block@vger.kernel.org, netdev@vger.kernel.org, nova-gpu@lists.linux.dev, dri-devel@lists.freedesktop.org, zhongqiu.han@oss.qualcomm.com References: <20260628-b4-rust-vertical-imports-v1-0-98bc71d4810b@gurudas.dev> <20260628-b4-rust-vertical-imports-v1-3-98bc71d4810b@gurudas.dev> Content-Language: en-US From: Zhongqiu Han In-Reply-To: <20260628-b4-rust-vertical-imports-v1-3-98bc71d4810b@gurudas.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 2o1NyfsN1S3P7NodgtcTJFeNO_BiAai1 X-Proofpoint-ORIG-GUID: 2o1NyfsN1S3P7NodgtcTJFeNO_BiAai1 X-Authority-Analysis: v=2.4 cv=Ftk1OWrq c=1 sm=1 tr=0 ts=6a42687c cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=ecjbvcZnrCEMvoAzKiMA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDEwNSBTYWx0ZWRfXwwKizwvb+U94 FSWlBWNxL1pfYVt/prWldFQqqYnkRX9dHK6rSSfjtX9IGUN6Y8XHKZT0y/28lTh7XuwCCRPrLA4 YwHQgmoANyMoA08GyM9axqOfE5/aVjc= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDEwNSBTYWx0ZWRfX5tBXgJesmzP7 pBvR9/i5cu+EzYd9DDljXm/u76gXIk96EDwlJKMbWn7M9I7YpNE/y66N7eZgakPlXWeEiU7kTze F2llAVx9fxbp+sThNljktFwmcyFcPC18q+y+L8qVKHpQfsGcdrReEdgaO+RjW+luA2X5nH8h+5I 7UIXIZKNbN6CrCIRlYwc0U/2xHijaqpUDQX0wZzn8cZCmZxZtxzMxic3SHjYcRD45tYSuyBEasw I9QLZZIGyMdiEMTyfHQ/NgTMPFIl+3bVRNrM/7vIjA3QzaDOObi8salQOa8JXLqOxZG4i3c+TUt osAfHSkJuID4LNBqZ4ekqMk6BJXEAIVjj8pht150CUMTivwQ5Z9efaA/swHuBPubU5IEZJBXRig pmYsGXSndQrPrDPQ8Sf3EaotBoMElVZJm05JNviXK47puwT/NF4ye5UtxSCSEQGWSrU+bgfO6cC vt+dCSt/Ud04kxgG7XA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 phishscore=0 priorityscore=1501 malwarescore=0 spamscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290105 On 6/29/2026 11:38 AM, Guru Das Srinagesh wrote: > Convert `use` imports to vertical layout for better readability and > maintainability. > > Signed-off-by: Guru Das Srinagesh > --- > drivers/cpufreq/rcpufreq_dt.rs | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > Hi Guru Das, > diff --git a/drivers/cpufreq/rcpufreq_dt.rs b/drivers/cpufreq/rcpufreq_dt.rs > index 10106fa13095..6f83cf8955a6 100644 > --- a/drivers/cpufreq/rcpufreq_dt.rs > +++ b/drivers/cpufreq/rcpufreq_dt.rs > @@ -6,7 +6,10 @@ > clk::Clk, > cpu, cpufreq, The change seems reasonable according to the Rust coding guidelines: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/tree/Documentation/rust/coding-guidelines.rst#n44 "each item goes into its own line, and braces are used as soon as there is more than one item in a list." If the preferred style is to place each imported item on its own line, shouldn't imports such as cpu, cpufreq, be formatted similarly as well? Have you run: "make LLVM=1 rustfmtcheck" on this change? > cpumask::CpumaskVar, > - device::{Core, Device}, > + device::{ > + Core, > + Device, // > + }, > error::code::*, > macros::vtable, > module_platform_driver, of, opp, platform, Likewise? > -- Thx and BRs, Zhongqiu Han