From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3126C4338F for ; Wed, 28 Jul 2021 22:29:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC5CE603E9 for ; Wed, 28 Jul 2021 22:29:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232627AbhG1W3t (ORCPT ); Wed, 28 Jul 2021 18:29:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232571AbhG1W3s (ORCPT ); Wed, 28 Jul 2021 18:29:48 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55F31C061757 for ; Wed, 28 Jul 2021 15:29:46 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1m8s3a-0004mh-Tb; Thu, 29 Jul 2021 00:29:42 +0200 Subject: Re: [PATCH v2] KEYS: trusted: fix use as module when CONFIG_TCG_TPM=m To: Jarkko Sakkinen Cc: James Morris , "Serge E. Hallyn" , James Bottomley , Mimi Zohar , Sumit Garg , David Howells , Herbert Xu , "David S. Miller" , kernel@pengutronix.de, Andreas Rammhold , David Gstir , Richard Weinberger , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org References: <20210721160258.7024-1-a.fatoum@pengutronix.de> <20210727030433.3dwod2elwtdkhwsc@kernel.org> <20210728215200.nfvnm5s2b27ang7i@kernel.org> From: Ahmad Fatoum Message-ID: Date: Thu, 29 Jul 2021 00:29:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210728215200.nfvnm5s2b27ang7i@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.07.21 23:52, Jarkko Sakkinen wrote: > On Tue, Jul 27, 2021 at 06:24:49AM +0200, Ahmad Fatoum wrote: >> On 27.07.21 05:04, Jarkko Sakkinen wrote: >>>> Reported-by: Andreas Rammhold >>>> Fixes: 5d0682be3189 ("KEYS: trusted: Add generic trusted keys framework") >>>> Signed-off-by: Ahmad Fatoum >>> >>> Is it absolutely need to do all this *just* to fix the bug? >>> >>> For a pure bug fix the most essential thing is to be able the backport >>> it to stable kernels. >> >> Not much happened in-between, so a backport should be trivial. >> I can provide these if needed. > > "not much" is not good enough. It should be "not anything". "Not much" [code that could conflict was added in-between]. I just checked and it applies cleanly on v5.13. On the off chance that this patch conflicts with another stable backport by the time it's backported, I'll get a friendly automated email and send out a rebased patch. Cheers, Ahmad > > /Jarkko > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |