From: Chanwoo Choi <cwchoi00@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] devfreq: exyos-bus: drop of_match_ptr for ID table
Date: Mon, 13 Mar 2023 19:37:42 +0900 [thread overview]
Message-ID: <f1019d0e-78ec-2783-5537-b8759993064b@gmail.com> (raw)
In-Reply-To: <20230311173753.263390-1-krzysztof.kozlowski@linaro.org>
On 23. 3. 12. 02:37, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here).
>
> drivers/devfreq/exynos-bus.c:504:34: error: ‘exynos_bus_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/devfreq/exynos-bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
> index 027e8f336acc..f7c554051232 100644
> --- a/drivers/devfreq/exynos-bus.c
> +++ b/drivers/devfreq/exynos-bus.c
> @@ -513,7 +513,7 @@ static struct platform_driver exynos_bus_platdrv = {
> .driver = {
> .name = "exynos-bus",
> .pm = &exynos_bus_pm,
> - .of_match_table = of_match_ptr(exynos_bus_of_match),
> + .of_match_table = exynos_bus_of_match,
> },
> };
> module_platform_driver(exynos_bus_platdrv);
Applied it with 'PM / ' prefix to keep the consistent title style.
- PM / devfreq: exyos-bus: drop of_match_ptr for ID table
--
Best Regards,
Samsung Electronics
Chanwoo Choi
prev parent reply other threads:[~2023-03-13 10:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 17:37 Krzysztof Kozlowski
2023-03-13 10:37 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1019d0e-78ec-2783-5537-b8759993064b@gmail.com \
--to=cwchoi00@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®