From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9737FC4338F for ; Sat, 21 Aug 2021 08:42:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 733DD611ED for ; Sat, 21 Aug 2021 08:42:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233291AbhHUInD (ORCPT ); Sat, 21 Aug 2021 04:43:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232802AbhHUInC (ORCPT ); Sat, 21 Aug 2021 04:43:02 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 278D5C061575 for ; Sat, 21 Aug 2021 01:42:23 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id o15so7261563wmr.3 for ; Sat, 21 Aug 2021 01:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Qucvdp5Gyww15sMosC3nYP8B70DNCNLtvx4YiBDHnTg=; b=tvxGmn2Cm9RpNqy9ty1Lfo4RxBHbj1e3B3A+aOVoegb0lHpGBBo7WRAPJgaLFSD5Kd fmksHpldW28Kl7bRBtfoanmMINzOi8wVRfzu2TnQTpdw/JpaxDpekPwlbIOFatviuC8s OjTGOtzPEF1GjqAv1iYMa/9e7giTuCbbfxNXOFRoCQ+2tGDOrAFOsMkbT8ovVXt6WMuy ZXbiyDpGPvndkW9oKYHdI80KbeJUeTnSQSGkuULhv4xQAoERD3Hv8hdKKtiMIvgS6FPx CmrgIN0aSPd/AsMAYRZ3hJ3VicuCuYlqNF7bNCnCW6SRODx7Lrr7Jhaq0Pc2mNrekbei PgbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Qucvdp5Gyww15sMosC3nYP8B70DNCNLtvx4YiBDHnTg=; b=BYUWHX20rPwSgkvH9CSb3xkgrLOYeG1em84aDbM7JY5IM8MQvLAGx+jXZIEHFRxkAf ko4hSLZioSfdBKnBjEg1otxw3g2Mjp9ydGLJ0TSPArXKw2x9RNgYmvJdSe9WE9tMPFql ZvndFG1lQMC7bg99jitX7c8MEu9dUi+p2SMIQmTLhhmUWaHGSOOU+X+NbLDR2IAItJMr dki/u8nVG1JRDxdbo6HqoWyCbyceaoNexuXElWy3uLUDDJ3tluqDnp2aiV7p7G+Yn9ta VahIbtYuz7D5m5eGyphZsX31Lxkin8fkSjuLnTWsC7l6886ylNdEHahZUcaoGk5s3rdz 0kjg== X-Gm-Message-State: AOAM531pDsdDbjot2y1bjflNf2TkDaUX1JqBH8EJO78LFm3kz4RLxcNA m3o7CMqgKqryZmSvttDvBnZ93Ljgm14= X-Google-Smtp-Source: ABdhPJx65d+HnQI7DSBGIWmbqq6fqsZ+3uUqb2H8wgHO7lQHGe93ndzFg5vYs6i+8LtdTtm667a+eg== X-Received: by 2002:a05:600c:414f:: with SMTP id h15mr7553831wmm.66.1629535341275; Sat, 21 Aug 2021 01:42:21 -0700 (PDT) Received: from ?IPv6:2a02:8108:96c0:3b88::2744? ([2a02:8108:96c0:3b88::2744]) by smtp.gmail.com with ESMTPSA id d8sm8219600wrx.12.2021.08.21.01.42.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Aug 2021 01:42:20 -0700 (PDT) Subject: Re: [PATCH] staging: r8188eu: Fix a resource leak in update_bcn_wps_ie To: Xiangyang Zhang , gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20210821081824.14745-1-xyz.sun.ok@gmail.com> From: Michael Straube Message-ID: Date: Sat, 21 Aug 2021 10:41:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210821081824.14745-1-xyz.sun.ok@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/21/21 10:18 AM, Xiangyang Zhang wrote: > The "pbackup_remainder_ie" variable is not freed when "pwps_ie_src" is null > > Fixes: 15865124feed ("staging: r8188eu: introduce new core dir for RTL8188eu driver") > Signed-off-by: Xiangyang Zhang > --- > drivers/staging/r8188eu/core/rtw_ap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_ap.c b/drivers/staging/r8188eu/core/rtw_ap.c > index 1127e9a52458..2ce982390c7b 100644 > --- a/drivers/staging/r8188eu/core/rtw_ap.c > +++ b/drivers/staging/r8188eu/core/rtw_ap.c > @@ -1300,7 +1300,7 @@ static void update_bcn_wps_ie(struct adapter *padapter) > > pwps_ie_src = pmlmepriv->wps_beacon_ie; > if (!pwps_ie_src) > - return; > + goto exit; > > wps_ielen = (uint)pwps_ie_src[1];/* to get ie data len */ > if ((wps_offset + wps_ielen + 2 + remainder_ielen) <= MAX_IE_SZ) { > @@ -1314,6 +1314,7 @@ static void update_bcn_wps_ie(struct adapter *padapter) > pnetwork->IELength = wps_offset + (wps_ielen + 2) + remainder_ielen; > } > > +exit: > kfree(pbackup_remainder_ie); > } > > Looks good to me. Acked-by: Michael Straube Thanks, Michael