From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E5B978F3A for ; Mon, 10 Aug 2026 03:14:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786331662; cv=none; b=L6S2iyMmy+2y6F3cHC99YXHOBPlLRrB8nQ1pqeH8zN0Hkjj/ImcCcc1lSpXAIJdMPikeGysRcgAt1Ms96rC80zg6fVHpxefghLj07+rwFCn8Qh6DsNA4aP8CZC4fLjA1KEV9LDo/F6owETZL4xRuw5OzI/rpKPM/NtxGGDHa86U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786331662; c=relaxed/simple; bh=hJVZGjdzMszsM5bjwrmT88RtUDhCOhiCTzcuewL63EY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iBV6aPeV+ZFBGK/DtZZE3bp4SiCe3y23Pxec+/w/3EWY8yvkiTe/tlQu9jX+is99srvNrPy4SK3ezWFCUwwP10OncqaD6I3706ePgGSPKX6M2su+Vt4ms79u96J2tb7kHBaPkPddv7zK1Qk+DRZWgLLlIlsBad7VSDmXqqOTw6I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PCjKCX5O; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YXSUJvB/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PCjKCX5O"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YXSUJvB/" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 679MGfKr3617048 for ; Mon, 10 Aug 2026 03:14:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= c20YFg7R+aIz/hgdPzYueBJ9BwfxuVTOpY3oG8UMOr0=; b=PCjKCX5Ofd+7t3oH jGFoKUF1nRrglUXU2SIReN7qrYQ2HncGc+x/56ijyhXfXyjosTfaopA13lvnBFuz QSLuwioIX7ZQuYffzZ00RcWHsu3ykXYxz5T/Zj6u7UcmPPbANFV57YUz3vqryp7o e/egEF6jIhNZFEQ90cE3Av1v6gaEu6T7Ee3xZfPuly/xRuxLqBAHbDtIC9406HqA sObhoyFKPKGqsyo3OxOhgPJgoi9Gh+cRj4aNWFWEQEbReqBw8EXCpmIkWT28/gNj SDQRAJg6DDBUH4EMkYWsPamzAI9j5r66VcA1tdswOZXpZ1W000R80/jMf9S3YyFW H/w1oA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fww7cv3n1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 10 Aug 2026 03:14:20 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c12e43b98so15736401cf.1 for ; Sun, 09 Aug 2026 20:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786331655; x=1786936455; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=c20YFg7R+aIz/hgdPzYueBJ9BwfxuVTOpY3oG8UMOr0=; b=YXSUJvB/LR639BRMr16COatmxzLXQOvVp9KA+Ss09ZbvcrKjEAEvuud+wGCy0f6tsz uFlCeDHLKuWF7xrC37B4UOxc6uwU9a9oHohGbvkxHQxcWsLVGx5B9TGlNAHS7iOF5EO0 SEv6khmT+nOEPE5TOzRjLtQr8oNbAIJQFLlMaEp6q6il8qITc8IxFikpBh452GmGk2JR bFOnbKk4PUCuBRO94gNtJij2nmG4XLEeVdIsRrcdO7ThgsKGoApcX34ZeChQTbwtOiXk 9ld/kC3MGEyJPZplvtx04fhQiUBasg168+s/qvH8lcU9vF64PUQCvS0qn1G6AQKFgi+b gAoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786331655; x=1786936455; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=c20YFg7R+aIz/hgdPzYueBJ9BwfxuVTOpY3oG8UMOr0=; b=cpLU1IXALPaW8z6Lk7l6dDqucn6hYLBV+eJ/RmazeNZ343wyLi0mEDQugY97omfX9w cvaDUh6ESvd49JFFrCGNF6WCjtDhs2mawKwQWLdcDcWTYfbv0rIHrE0OVjGJC8Wz+n3Z D436S6RZXRiHsu9yazpLk33zTdhxwQERGAuFzspnqx4xY8JtzHYnYLhagCTrVdqN0OaX kvEColVgar4kH8jwVurWnTaJ46N7k0Z6MeKthi8EcrAprKwAqVwIZqp6yDuJH6C88pFC 9URahvd5LNbdN2+X2+y+OznGsvaXt+Se8zgkz+FSlAVDEk+7b/TGZ9cAydC0tZgq+ZM/ KWNQ== X-Forwarded-Encrypted: i=1; AHgh+RrW5ZfEYK3yn8hg304i69SJS0w7yNk0LhIQclB6geqNyBGzikWSi3LQvow7lAK0A9yHAKc8HcQldIrz6IU=@vger.kernel.org X-Gm-Message-State: AOJu0YwKoIPM8oGnfes7QGO2GpO4xvxmwwYovbgxblT+F4sVJViY6KvP zAsSAXKEXKJlsw2Ag0rDv4359Sc3GMDfIy1gDKD43mcVyoV6057FX9sZYXeysgte5P2PHoJix0Y NpuUtSR834jCZTC+oj6GWSZkoRRdiTrfkBZT+9r8qAUau+PFBF9Ihar//TsAZVVcLAAe/t2wD4A 0= X-Gm-Gg: AR+sD13K52iiYFJR7yIT9eaVaFq+rW0DEeUAwLUpI8NXFnWfo9rj5Cqh5ol+o4KViMP rJbW17OaSzkgqDp4YDPePE2YrfuQMXAYK079ej3axJFqAvV7a7P+1dZq38IcucXEizpuvkfS9KZ GS+YCheEfpBtZadduYMIOaCJqAC7d6y6D0CM/yRTpFEmUPl8TM2fMoxn96D/7Aqj4q3Q4vpOsRb 4CqjLzQ6flggfLbTmbK9fCZ+5O1IVfFCjwo28emCere1kgDQ1eLCEpq3ufRp3lFLghYxvYeehg1 9PDXDYkVYT6WnAV17z/1UgWXN7z8xX9L3B6ykkPWuq8SkLtMTpzGgVv5Z8aFsXJguAG+k/5Y98z n0ZMzDYwsqPDZgEG6jeXik/zIS13IGkDsrf4= X-Received: by 2002:ac8:58ce:0:b0:528:162e:29d3 with SMTP id d75a77b69052e-52ce614ba88mr400898741cf.32.1786331654626; Sun, 09 Aug 2026 20:14:14 -0700 (PDT) X-Received: by 2002:ac8:58ce:0:b0:528:162e:29d3 with SMTP id d75a77b69052e-52ce614ba88mr400898361cf.32.1786331654128; Sun, 09 Aug 2026 20:14:14 -0700 (PDT) Received: from [192.168.69.229] (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-480021501bcsm29134102f8f.9.2026.08.09.20.14.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Aug 2026 20:14:13 -0700 (PDT) Message-ID: Date: Mon, 10 Aug 2026 05:14:12 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] serial: sb1250-duart: Fix bootconsole handover lockup Content-Language: en-US To: "Maciej W. Rozycki" , Thomas Bogendoerfer , Greg Kroah-Hartman , Jiri Slaby Cc: linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org References: From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: -O60ynJzwpRYQ5VPQZaGd-UzYVDNJPJN X-Proofpoint-ORIG-GUID: -O60ynJzwpRYQ5VPQZaGd-UzYVDNJPJN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEwMDAyNCBTYWx0ZWRfX0lbQyvNIkMuO wdriCUu9CLjMdHL0d8aJz8LIRun0pHchcOTCKGZwxxG2aozuK4X3jH2JXR+ZIWCjeJGQKocRvcL oIR2CHthEdztyOYx+ApvVMKEx7ZTUtGEL5fn6JkyQkBjLya72lwZv9fbnlrmbmltUYU74qMdpV+ x6+c/Lxd0vj8SHg36AsYmk44BgaAriG8DVBStzdw7ICm9TX9IYEk2tY4ZqD3JN2fmXYJ06SOtK8 A/z6muADXr+5xsCkBuHvKqdjqYrZwWbVhpB8seqgnaX0dKCgBSUbMwxDubZ5OELAq076MrRi2r8 AmS3zdW2iEnDUuNa//KarJv9U9tH7l5+hNZVZx3fssWDE1P5mE+8f3rA+JMjFxbLIeyS/Wis7xU Oxz7rKjQwZxfu8jH1A0+I2jeAyHfgVnghG1TwlFhukcbWQgPHmZI8Dr7JcOWXOAVYBG+fjb3IXo bC/oAKmO2fmJZrMjk8w== X-Proofpoint-Spam-Info: AW1haW4tMjYwODEwMDAyNCBTYWx0ZWRfX2LkiXOsn5Trq eaX8zXpdbFBO4uaRlGTdoXdOa6xWeajKx6EuNtylZpsoAlozVS/MsFoFOk1KvgloAuydu6KrrKj MXv6V4XRqEyv/bv11NP2YFB2tk4Y64Q= X-Authority-Analysis: v=2.4 cv=IPsyzAvG c=1 sm=1 tr=0 ts=6a79420c cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=BcPKCTjPAAAA:8 a=EUspDBNiAAAA:8 a=_xeo5rayHQ2-IrAwGUsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=MNXww67FyIVnWKX2fotq:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-09_07,2026-08-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 bulkscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608100024 On 6/8/26 12:54, Maciej W. Rozycki wrote: > Calling sbd_init_port() in the course of setting up the serial device > causes line parameters to be messed up and the transmitter disabled. > We've been lucky in that no message is usually produced to the kernel > log between this call and the later call to uart_set_options() in the > course of console setup done by sbd_serial_console_init(), or the system > would hang as the console output handler in CFE tried to access a port > whose transmitter has been disabled and line parameters messed up. > > It'll change with the next change to the driver, so fix sbd_init_port() > such that line parameters are set for 115200n8 console operation as with > the CFE firmware and the transmitter re-enabled after reset. > > Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM") > Signed-off-by: Maciej W. Rozycki > Cc: stable@vger.kernel.org # v6.5+ > --- > No change from v2 (2/3), > . > > Changes from v1 (2/4), > : > > - Sanitise the change heading. > --- > drivers/tty/serial/sb1250-duart.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > linux-serial-sb1250-duart-prom-console.diff > Index: linux-macro/drivers/tty/serial/sb1250-duart.c > =================================================================== > --- linux-macro.orig/drivers/tty/serial/sb1250-duart.c > +++ linux-macro/drivers/tty/serial/sb1250-duart.c > @@ -542,14 +542,19 @@ static void sbd_init_port(struct sbd_por > /* There is no DUART reset feature, so just set some sane defaults. */ > write_sbdchn(sport, R_DUART_CMD, V_DUART_MISC_CMD_RESET_TX); > write_sbdchn(sport, R_DUART_CMD, V_DUART_MISC_CMD_RESET_RX); > - write_sbdchn(sport, R_DUART_MODE_REG_1, V_DUART_BITS_PER_CHAR_8); > + write_sbdchn(sport, R_DUART_MODE_REG_1, > + V_DUART_PARITY_MODE_NONE | V_DUART_BITS_PER_CHAR_8); > write_sbdchn(sport, R_DUART_MODE_REG_2, 0); > + write_sbdchn(sport, R_DUART_CLK_SEL, V_DUART_BAUD_RATE(115200)); > write_sbdchn(sport, R_DUART_FULL_CTL, > V_DUART_INT_TIME(0) | V_DUART_SIG_FULL(15)); > write_sbdchn(sport, R_DUART_OPCR_X, 0); > write_sbdchn(sport, R_DUART_AUXCTL_X, 0); > write_sbdshr(sport, R_DUART_IMRREG((uport->line) % 2), 0); > > + /* Re-enable transmission for the initial PROM-based console. */ > + write_sbdchn(sport, R_DUART_CMD, M_DUART_TX_EN); > + > sport->initialised = 1; > } > Reviewed-by: Philippe Mathieu-Daudé