From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C03252A1BB for ; Mon, 5 Jan 2026 09:33:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767605597; cv=none; b=QgO5vidlPFhXNR/OOf9YJZOYyldx58x306AqxuAUMB6VO69SMSlTx2KbDUCmbl43/MLwe0EkZKDifltnyADC/wNpssuJw4VWHY8rkyfROeGHfAM3yB/4NvVEKAZMPVgR6+bnTycEi/a4pzMJj2TowCYmbhGXQCpXpA/W9Va9tmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767605597; c=relaxed/simple; bh=f9G+TZhpfGyr+FNVp1/8mKZMEmcK1fVbMUD7E8dxBR0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m2DxXoycvEfvBVZ47SvMiZFBICqV633KdKjcB6FraT8XWv4E9vfYcgkYG7Sahw9OpFt3BslCuzDifWM2nB0KuLl8jXf3vuEmmOC4C1MyJez3sGDecdQhr9pa0f4+5X4lZMupc7Pi7ErRdZTXdFiIUeLE6dXTvT/yQMThLxSq6Lg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9FB2E497; Mon, 5 Jan 2026 01:32:58 -0800 (PST) Received: from [10.163.86.15] (unknown [10.163.86.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4A8603F5A1; Mon, 5 Jan 2026 01:33:04 -0800 (PST) Message-ID: Date: Mon, 5 Jan 2026 15:03:00 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] memblock test: include from tools mm.h stub To: Mike Rapoport , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org References: <20251228183942.3628918-1-rppt@kernel.org> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20251228183942.3628918-1-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 29/12/25 12:09 AM, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > memblock test compilation fails: > > memblock.c: In function ‘memblock_validate_numa_coverage’: > memblock.c:784:58: error: ‘SZ_1M’ undeclared (first use in this function) > 784 | mem_size_mb = memblock_phys_mem_size() / SZ_1M; > | ^~~~~ > > The SZ_1M is defined in sizes.h, but it is not included by stub version of > mm.h in tools/include/linux. > > Add include of sizes.h to tools/include/linux/mm.h to fix the compilation > of memblock tests. > > Signed-off-by: Mike Rapoport (Microsoft) > --- > tools/include/linux/mm.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/include/linux/mm.h b/tools/include/linux/mm.h > index 677c37e4a18c..028f3faf46e7 100644 > --- a/tools/include/linux/mm.h > +++ b/tools/include/linux/mm.h > @@ -4,6 +4,7 @@ > > #include > #include > +#include > > #define PAGE_SHIFT 12 > #define PAGE_SIZE (_AC(1, UL) << PAGE_SHIFT) Reviewed-by: Anshuman Khandual