From: Guenter Roeck <linux@roeck-us.net>
To: Joaquin Aramendia <samsagax@gmail.com>
Cc: "Derek J. Clark" <derekjohn.clark@gmail.com>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (oxp-sensors) Differentiate new BIOS for the Mini
Date: Sat, 27 May 2023 05:19:14 -0700 [thread overview]
Message-ID: <f10a1c61-bc8b-420f-988d-ba0ebfccf00f@roeck-us.net> (raw)
In-Reply-To: <CABgtM3jNVp63XB5A8Cf0KhB4So2==HLGa9_meuTn0vHYy=gBzQ@mail.gmail.com>
On Fri, May 26, 2023 at 08:42:51PM -0300, Joaquin Aramendia wrote:
> > On Fri, May 26, 2023 at 06:56:22PM -0300, Joaquín Ignacio Aramendía wrote:
> > > Newer BIOS got some other changes aside from string changes. Add a board
> > > enum to differentiate it from the old OneXplayer Mini AMD BIOS.
> > >
> >
> > I see no functional difference. What is the point of this change ?
> >
> > Thanks,
> > Guenter
>
> It is nothing right now, honestly. But is necessary for a later change
> i have queued and a bit of OCD on my part. Should I add this to the
> other change?
>
It can stay as separate patch, but please resubmit it together with
the patch(es) actually using it.
Guenter
next prev parent reply other threads:[~2023-05-27 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 21:56 Joaquín Ignacio Aramendía
2023-05-26 23:31 ` Guenter Roeck
2023-05-26 23:42 ` Joaquin Aramendia
2023-05-27 12:19 ` Guenter Roeck [this message]
2023-05-27 12:55 ` Joaquin Aramendia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f10a1c61-bc8b-420f-988d-ba0ebfccf00f@roeck-us.net \
--to=linux@roeck-us.net \
--cc=derekjohn.clark@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samsagax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®