From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751977AbeAEOWu (ORCPT + 1 other); Fri, 5 Jan 2018 09:22:50 -0500 Received: from mail-sh2.amlogic.com ([58.32.228.45]:11219 "EHLO mail-sh2.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751845AbeAEOWr (ORCPT ); Fri, 5 Jan 2018 09:22:47 -0500 Subject: Re: [PATCH 4/6] ARM64: dts: meson-axg: uart: Add the pinctrl info description To: Jerome Brunet , Kevin Hilman , References: <20180105095621.196472-1-yixun.lan@amlogic.com> <20180105095621.196472-5-yixun.lan@amlogic.com> <1515148123.5048.22.camel@baylibre.com> CC: , Neil Armstrong , Rob Herring , Mark Rutland , Carlo Caione , , , From: Yixun Lan Message-ID: Date: Fri, 5 Jan 2018 22:22:43 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1515148123.5048.22.camel@baylibre.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [58.34.185.131] X-ClientProxiedBy: mail-sh2.amlogic.com (10.18.11.6) To mail-sh2.amlogic.com (10.18.11.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/05/2018 06:28 PM, Jerome Brunet wrote: > On Fri, 2018-01-05 at 17:56 +0800, Yixun Lan wrote: >> Describe the pinctrl info for the UART controller which . >> + uart_a_cts_rts_pins: uart_a_cts_rts { >> + mux { >> + groups = "uart_ctx_a", > > uart_ctx_a does not exist in pinctrl > sorry, it's a typo, it's uart_cts_a em. end of the Friday is really bad time for me to compose the patches.. >> + "uart_rts_a"; >> + function = "uart_a"; >> + }; >> + }; >> + >> + uart_b_x_pins: uart_b_x { >> + mux { >> + groups = "uart_tx_b_x", >> + "uart_rx_b_x"; >> + function = "uart_b"; >> + }; >> + }; >> + >> + uart_b_x_cts_rts_pins: uart_b_x_cts_rts { >> + mux { >> + groups = "uart_cts_b_x", >> + "uart_rts_b_x"; >> + function = "uart_b"; >> + }; >> + }; >> + >> + uart_b_z_pins: uart_b_z { >> + mux { >> + groups = "uart_tx_b_z", >> + "uart_rx_b_z"; >> + function = "uart_b"; >> + }; >> + }; >> + >> + uart_b_z_cts_rts_pins: uart_b_z_cts_rts { >> + mux { >> + groups = "uart_cts_b_z", >> + "uart_rts_b_z"; >> + function = "uart_b"; >> + }; >> + }; >> + >> + uart_ao_b_z_pins: uart_ao_b_z { >> + mux { >> + groups = "uart_ao_tx_b_z", >> + "uart_ao_rx_b_z"; >> + function = "uart_ao_b_groupz"; > > "uart_ao_b_groupz" function does not exist in pinctrl typo, uart_ao_b_gpioz > .