From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6536B2D12F5 for ; Fri, 19 Dec 2025 05:42:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766122945; cv=none; b=r1r7mwhRZst5topZlf1XNOiK8rOhAMSpQnqTGTYVrdrCS2/oogR+5rgWRF6CfdlyRDtIIPP8Hk3rJQ+PfZ72joZ8kF4jJ6rd+qUR5M9pPzbRj0uI/6+v1ayCULnFyOpoO6o59GfX5y8O2pzmCq1kgP23jHlGw+YsL7A4iOt4JYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766122945; c=relaxed/simple; bh=gzvBQaQE04aWx7Tv8hc+MsWpJrIp26psxmc1jwDn7E8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tAd1ZXWOpyr5EEiMWkalgYYTb4EL1TB7V6R7Ez6dRNE24EhwjFPC/lg4C1PByfUnLzDb6PzFsqCsEvLbIZztlTxtRj3J5Qz6OmejD96//5yiFHN8pv/J3aWje3ui8HljKBULqIstOVMr4HZDZFmlEulgtxrYO3Vo2flrAbSGnOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IOb6IjT2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bP8mTEDX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IOb6IjT2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bP8mTEDX" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJ4cUfF4000205 for ; Fri, 19 Dec 2025 05:42:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= V5m5tAGlkGiYi81yuxiUUxECa/gsyO0V5obb+kA+4XI=; b=IOb6IjT2KCeaFFPC qbitY9mejvNfAxdKwcHxSJbGLgBr8OIIyVT11AEGgsmrICPi9htrwSU+Bf85Dc8f 03Sbs23Bx0da+FJIYI0mA/Me5t7IHYnNwMC5Rf0SOnKnNmHAUCwEdfYrAAXguM76 zuZHnrzzBaSrhrHbpmFbmr/fdiM/g5OI4sobhw5mZ/RPVtxyQpgr6uk4EtUyALuD cqa1hChjSuVRnGpciftph0et4RaS0Bw76toj58e/2OIFpb/YUD+UHkMZGSL3VLlU M3EZq0WIHG8xcpBWzXTz4zp84djn7TKy5FiJU/vSsRw/0BJcSHqMB5uw3S+bsXk6 hBVKvw== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r29hcsq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 05:42:22 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-ba4c6ac8406so1205618a12.0 for ; Thu, 18 Dec 2025 21:42:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766122941; x=1766727741; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=V5m5tAGlkGiYi81yuxiUUxECa/gsyO0V5obb+kA+4XI=; b=bP8mTEDXgyNIGwM4I/cmnI0speWD7RwG2Pp/ktvFFEtLjcNKmvhDVPYjWgSc1oZi2b 6TDtHND182r2D5PbKO6ti+svPlakAl0BKZZVFT8fLYEVrHRNVirJRbegaJtbgtUCd7dx iEeK08HWLimxzJS8BGgHHHKoUC0XyyWxwsjnKU4DRjHDcYzrKStJtMzbXHeF3MxfNXYo rb73/XrS7aC2w8mAPBJNd1/nQgRdHfOXgG/Zt75xvTYrWJN3PmGJu1BHy+NmlqGRRibJ UmmUmPZaqLwysQRbv1MNAvLFybrg0765ZkImnC4DtpEwaIDlww38iNq42qFbr18e4N1f ZZcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766122941; x=1766727741; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V5m5tAGlkGiYi81yuxiUUxECa/gsyO0V5obb+kA+4XI=; b=IXRic5SYCpIqfy+3q2wE/Y8XEVV96R3FRiTikyKAAbFjFV8ObnSEXWerbSqBGjA1hJ tzdrxkDDZYbBlNAZb3oIHmjcORR4Wcdl+vFHSHHLKzsufFHtyaPR2ol2oY/dTgSTbJOB AKKGwAuU7TddbDHuFchxzt4EVwrgraI8l5BZJbo6CYTrFMmPLFXs1qlqtMhaEEnhn+dp DXm/j4Qhc757Ms54Xd76m9jVohP3HqxmFlP1ahADqgop9A4C3K6IvHA42wwOokjRlImo uP63qaySGP88b5vW7WT7HuZgG7QadyNW3Y7peB2MVFckZh/kIIrqmj/q/rK93C4IJLWj flVw== X-Forwarded-Encrypted: i=1; AJvYcCUhApuPdNkD2Vlp+m0FaRBA8t9kE80Xv5XCHhE1YxEySzNTp77DVrmOhb41B6ByMDbP9Dp2nk9rwsAz6Do=@vger.kernel.org X-Gm-Message-State: AOJu0YzuUpk3sUsNBaMpNif2wi0GvdxqOAL2uDGvL6pRRXDs10H8cKjE 1qgV3b/fUG/4w/SGfzaZvVA3igozSBgKzOsofleqvLyyDFk2H6TlDD3oJ7WNDCWg6hwv4dS/UjN APMGQ3g3zbbIYsDRPnKANBAxtoBw/+9mR1GgMKiMC8w8/O2ZWSBQva3ge0jvWRZPLGDc= X-Gm-Gg: AY/fxX7dt6kr1/PVvIo8Di0cR+vlHB4xVD21uSrIUEUxTyq1j0FNjXgvn46K4KP1jul oqxplwP4Kh+aAUEAzYLVTqaG12mA1ot+zh5gfzE1NyqcOI50OuoNmBMD2YClDaXddmlvSJG09e2 5qnDJkHNnKw9yhS6oragrOdVVWmSnUYodAQKy0D/GNzIpPPd718kxA7sCzYxs75aXt5EfNy3KV6 OO4LhD+T8O36OB9yVljY+mw93yNad99ePZe2DMKxqyE3nFQUOQ+dx/u+5VmSCUlP1UQpU5y79xJ GgPy4Ytj6Vz2KpK6zjC759gCTOBaWGiKcgXRVTGLwWwjFXwveCS8SItjyxiKpyrNYthE9OZwMWc M73UuYdfM9Llfn33Mu3QNZxBHebo3hBKp5kztX3+3m2sjmOGqbVxAsXrCQ3OiXVTbRgnf X-Received: by 2002:a05:7022:f693:b0:11b:803c:2cf5 with SMTP id a92af1059eb24-121722eb259mr2094563c88.33.1766122941352; Thu, 18 Dec 2025 21:42:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IEhk+4V4h85Zxgq/94CKGljiu1MRE42gFAPuVqCapM99qVbrJgOcmpXpxMamCypOIwWFCgFNw== X-Received: by 2002:a05:7022:f693:b0:11b:803c:2cf5 with SMTP id a92af1059eb24-121722eb259mr2094530c88.33.1766122940751; Thu, 18 Dec 2025 21:42:20 -0800 (PST) Received: from [10.110.90.237] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-121724de25dsm3836422c88.7.2025.12.18.21.42.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Dec 2025 21:42:20 -0800 (PST) Message-ID: Date: Fri, 19 Dec 2025 13:42:15 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH next] wifi: ath12k: clean up on error in ath12k_dp_setup() To: Dan Carpenter , Harsh Kumar Bijlani Cc: Jeff Johnson , Ripan Deuri , Vasanthakumar Thiagarajan , linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: From: Baochen Qiang Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=P6c3RyAu c=1 sm=1 tr=0 ts=6944e5be cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=S47APn7KmZlrf8u2960A:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: L1v3efoC3WZ7ScPz7CZ5iXT7gE-l5EE_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDA0NSBTYWx0ZWRfX1nvar/HFxTja Up17TG5r+E9O3RRXqVwXfVwZKXrPNX1pxyX3H/pwvTRaWdO9wIjXQG8miLat6MnpyxbqK3sAdU/ digXDLKcVaz4vmoI2EhgWWFxAL1CtB9EIfit3+jbGHiotfYAUypdBE/ed04/y+Y4EMDM1MryQ0R rSlhG67CUj97mwvAYMEXqaCgmgnTAKEw/trJ51I3Mh+XWqIHvWE24OcGetbzicwpFsZGu05B0ks KpyYnwSR6ve7z7sUuMAH7YxpyfeTAmwX15H8DPwNZt3oZeejBAnIbpbIyGxW9X1ENa7tB3lolR4 z5UbOkDYvTl4Hj78kavn4efit/YM9yj/gpgOJ75IJ/mscGjgBayGl6wheerhsEXnEOXU6wOqyfh MPJXYsvc4bYLDqPHB9uAcp85QzUsw10soQ8CvwkU9R50HNHqkrIDKNH5HTdMw2sl5pvblfun15u qMvHByJrexBhbhlcJtA== X-Proofpoint-GUID: L1v3efoC3WZ7ScPz7CZ5iXT7gE-l5EE_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_01,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 phishscore=0 priorityscore=1501 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190045 On 12/18/2025 3:44 PM, Dan Carpenter wrote: > Destroy the rhash_tbl before returning the error code. Would be better if the actual problem can be described first. > > Fixes: a88cf5f71adf ("wifi: ath12k: Add hash table for ath12k_dp_link_peer") > Signed-off-by: Dan Carpenter > --- > drivers/net/wireless/ath/ath12k/dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath12k/dp.c b/drivers/net/wireless/ath/ath12k/dp.c > index 9f05eea6695a..ab54c8a84d3e 100644 > --- a/drivers/net/wireless/ath/ath12k/dp.c > +++ b/drivers/net/wireless/ath/ath12k/dp.c > @@ -1513,7 +1513,7 @@ static int ath12k_dp_setup(struct ath12k_base *ab) > HAL_WBM_IDLE_LINK, srng, n_link_desc); > if (ret) { > ath12k_warn(ab, "failed to setup link desc: %d\n", ret); > - return ret; > + goto rhash_destroy; > } > > ret = ath12k_dp_cc_init(ab); However since this is trivial ... Reviewed-by: Baochen Qiang