From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A218C7EE2D for ; Mon, 22 May 2023 13:24:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234296AbjEVNYw (ORCPT ); Mon, 22 May 2023 09:24:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234046AbjEVNYm (ORCPT ); Mon, 22 May 2023 09:24:42 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1456B7 for ; Mon, 22 May 2023 06:24:40 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-3f50020e0f8so23619285e9.0 for ; Mon, 22 May 2023 06:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent.com; s=google; t=1684761879; x=1687353879; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Fbjva5UnX0GGH/ZxZ0X0CMHpFHlYx9oYRC6yISvpo2Q=; b=YYx3U7N+8aTfiQBFTVQpq0s9ZGFpDes1bkg36nW/w8Qd4sYjKHRTh8jT/J0XM0ieUJ ya5amTtiqAW9QUSZzvoN03/0FfLA/3KFlO+wgO8AyEmNr+iS3r7iZBsR/vp+1Y4++MYe jxEQwTEtrzumU5SqTzPJ8jeAL9BECFrz8k9im6AFxlyrR7VSPwNIXMNlJOnartYhm7/o SVd1dzOFODL4lf1UO0OmAfd2cQ6nTqlZkv9/NWZv0us94vRWttFRRtIuP64sRmWxweWZ eyWJg1FV2T71bBX2+90juqYq5gotgJIvz23zh7A0r3twe5BKhFZYigNPkMZnQrOUdVXm 3gCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684761879; x=1687353879; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Fbjva5UnX0GGH/ZxZ0X0CMHpFHlYx9oYRC6yISvpo2Q=; b=YIsIORTmEU+iIgCRRaCJr2CUTFKWbHU8adkGj+IAPyFw7GFWf/C7+yAMtckQQRlfMK qTJHJ3JXtn85U8zjC/H5XoBR8+8jc0V7FiOoYNfGOStJpxdj80QniMiiSnwn2iz9h3sV zWoUg8i1ixObvC7CYtkMZfdTWCH9ehwxC4hHn1gEPbv+HiJUc7++FL/4OTdmCecrYzAK gcSocG6F0ZKZ6ToI+kdvZu4Zex8o0e9uOB4IEqXzAe7wBVMsxwbg7g30clr++ZnI8XeY /ilaqOGq8NrPLsNZmKyNK4/JlwISQ4aGgzEOUKb1EzOtTcfiwvLFPb6pmhtNWNY8Dcme JpGA== X-Gm-Message-State: AC+VfDzQKy5WKqq1wrFMtyXSmUN4twNjcJYqsZKP/oXv99CjlcYnX9AV ci/2/vBAUMJu8En8ojnoZXMkhQ== X-Google-Smtp-Source: ACHHUZ7Tk/zLFZzPkrqvwom0yBqVrA8bZqXxQltRy8JCMPO21bCCveMRBKd6DuEw1MHtrT63zer3Ew== X-Received: by 2002:adf:dcc9:0:b0:30a:8e84:eaa8 with SMTP id x9-20020adfdcc9000000b0030a8e84eaa8mr2933871wrm.16.1684761879220; Mon, 22 May 2023 06:24:39 -0700 (PDT) Received: from ?IPV6:2a02:8011:e80c:0:50b6:8eff:3df4:1ebe? ([2a02:8011:e80c:0:50b6:8eff:3df4:1ebe]) by smtp.gmail.com with ESMTPSA id q2-20020a5d61c2000000b00309382eb047sm7716749wrv.112.2023.05.22.06.24.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 May 2023 06:24:38 -0700 (PDT) Message-ID: Date: Mon, 22 May 2023 14:24:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH bpf-next v2] bpftool: specify XDP Hints ifname when loading program Content-Language: en-GB To: Larysa Zaremba Cc: Stanislav Fomichev , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Hao Luo , Jiri Olsa , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Niklas_S=c3=b6derlund?= References: <20230517160103.1088185-1-larysa.zaremba@intel.com> From: Quentin Monnet In-Reply-To: <20230517160103.1088185-1-larysa.zaremba@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2023-05-17 18:01 UTC+0200 ~ Larysa Zaremba > Add ability to specify a network interface used to resolve > XDP Hints kfuncs when loading program through bpftool. > > Usage: > bpftool prog load [...] xdpmeta_dev > > Writing just 'dev ' instead of 'xdpmeta_dev' is a very probable > mistake that results in not very descriptive errors, > so 'bpftool prog load [...] dev ' syntax becomes deprecated, > followed by 'bpftool map create [...] dev ' for consistency. > > Now, to offload program, execute: > bpftool prog load [...] offload_dev > > To offload map: > bpftool map create [...] offload_dev > > 'dev ' still performs offloading in the commands above, but now > triggers a warning and is excluded from bash completion. > > 'xdpmeta_dev' and 'offload_dev' are mutually exclusive options, because > 'xdpmeta_dev' basically makes a program device-bound without loading it > onto the said device. For now, offloaded programs cannot use XDP hints [0], > but if this changes, using 'offload_dev ' should cover this case. > > [0] https://lore.kernel.org/bpf/a5a636cc-5b03-686f-4be0-000383b05cfc@linux.dev > > Signed-off-by: Larysa Zaremba Reviewed-by: Quentin Monnet Thanks!