From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 034AD13F6DFF for ; Mon, 30 Jul 2018 14:03:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1B3E20893 for ; Mon, 30 Jul 2018 14:03:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1B3E20893 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730513AbeG3Pir (ORCPT ); Mon, 30 Jul 2018 11:38:47 -0400 Received: from esa5.microchip.iphmx.com ([216.71.150.166]:16108 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726632AbeG3Pir (ORCPT ); Mon, 30 Jul 2018 11:38:47 -0400 X-IronPort-AV: E=Sophos;i="5.51,422,1526367600"; d="scan'208";a="14892083" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 30 Jul 2018 07:03:39 -0700 Received: from [10.145.4.77] (10.10.76.4) by chn-sv-exch07.mchp-main.com (10.10.76.108) with Microsoft SMTP Server id 14.3.352.0; Mon, 30 Jul 2018 07:03:36 -0700 Subject: Re: [PATCH v6 3/3] ARM: dts: at91: sama5d2 Xplained: add pin muxing for I2S To: Claudiu Beznea , , CC: , Cyrille Pitchen , , , References: <20180730114008.30464-1-codrin.ciubotariu@microchip.com> <20180730114008.30464-4-codrin.ciubotariu@microchip.com> <2e2bc99e-138e-fbc8-1db0-e37b46637af0@microchip.com> From: Codrin Ciubotariu Message-ID: Date: Mon, 30 Jul 2018 17:03:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <2e2bc99e-138e-fbc8-1db0-e37b46637af0@microchip.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.07.2018 16:49, Claudiu Beznea wrote: > Hi Codrin, > > On 30.07.2018 14:40, Codrin Ciubotariu wrote: >> From: Cyrille Pitchen >> >> This patch sets the pin muxing for the I2S controllers >> >> Signed-off-by: Cyrille Pitchen >> [codrin.ciubotariu@microchip.com: added pin muxing for the second >> controller] >> Signed-off-by: Codrin Ciubotariu >> --- >> >> Changes in v6: >> - none; >> >> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 28 +++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> >> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts >> index fcc85d70f36e..95cbec0f8790 100644 >> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts >> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts >> @@ -281,6 +281,11 @@ >> status = "okay"; >> }; >> >> + i2s0: i2s@f8050000 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_i2s0_default>; > > The approach with the disabled controllers in board DTS files (for our > boards) is to use the: status = "disabled" and if there are pin conflicts > with other controllers to put a mark in there, something like: > status = "disabled"; /* Conflict with X */ > > I'm seeing that i2s1 is in conflict with sdmmc1 and spi0. Ok, I will disable them and add the pin conflicts in the next version. Thank you for your review. Best regards, Codrin