From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16075C4167B for ; Mon, 11 Dec 2023 10:37:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234257AbjLKKhE (ORCPT ); Mon, 11 Dec 2023 05:37:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234234AbjLKKhA (ORCPT ); Mon, 11 Dec 2023 05:37:00 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A8DAD0; Mon, 11 Dec 2023 02:37:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702291027; x=1733827027; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=hHtobIbjGrWsDPGAnvtGAAfDp/QQJRNIOz1kL4DmbOw=; b=drtvES98zKyIrJDvCiLB6UlCFVH8mEkYoL9ZzlrJrt7bQw1+lAJKHA45 KeYGmiKAsxf/xIlNY/53f2DdkOK4+w6meoJ/sYCpug/cGTx4ItvbmuoK7 u+fqE+pf4AbpQAMoKdO/x7P0SH7EAhOK2DTgl7PDxaOQjDytiHlzcy+c9 v3OSnzybX6ra2FVNNxw6JvMmZRv3fRW3PHJjReh4r6Nk1C9GItByaFbNB Xqc/i8dbCcDRQTIv0e5yeTByQL66krf1TA8Ze7GNd06KxZYuWOzM/cFNL qckRywPz2gUF23E2zvoY1+kNrCitNBXJoKPJWO7CRXIYuuDVAbnhCieeC w==; X-IronPort-AV: E=McAfee;i="6600,9927,10920"; a="16180046" X-IronPort-AV: E=Sophos;i="6.04,267,1695711600"; d="scan'208";a="16180046" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2023 02:37:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10920"; a="772998121" X-IronPort-AV: E=Sophos;i="6.04,267,1695711600"; d="scan'208";a="772998121" Received: from lmckeon-mobl.ger.corp.intel.com (HELO iboscu-mobl2.ger.corp.intel.com) ([10.252.48.111]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2023 02:37:01 -0800 Date: Mon, 11 Dec 2023 12:36:59 +0200 (EET) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Lino Sanfilippo cc: Greg Kroah-Hartman , Jiri Slaby , u.kleine-koenig@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, cniedermaier@dh-electronics.com, hugo@hugovil.com, LKML , linux-serial , LinoSanfilippo@gmx.de, Lukas Wunner , p.rosenberger@kunbus.com, stable@vger.kernel.org Subject: Re: [PATCH v5 2/7] serial: core: set missing supported flag for RX during TX GPIO In-Reply-To: <20231209125836.16294-3-l.sanfilippo@kunbus.com> Message-ID: References: <20231209125836.16294-1-l.sanfilippo@kunbus.com> <20231209125836.16294-3-l.sanfilippo@kunbus.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1849002651-1702291025=:1867" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1849002651-1702291025=:1867 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT On Sat, 9 Dec 2023, Lino Sanfilippo wrote: > If the RS485 feature RX-during-TX is supported by means of a GPIO set the > according supported flag. Otherwise setting this feature from userspace may > not be possible, since in uart_sanitize_serial_rs485() the passed RS485 > configuration is matched against the supported features and unsupported > settings are thereby removed and thus take no effect. > > Cc: stable@vger.kernel.org > Fixes: 163f080eb717 ("serial: core: Add option to output RS485 RX_DURING_TX state via GPIO") > Signed-off-by: Lino Sanfilippo > --- > drivers/tty/serial/serial_core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c > index a0290a5fe8b3..c254e88c8452 100644 > --- a/drivers/tty/serial/serial_core.c > +++ b/drivers/tty/serial/serial_core.c > @@ -3632,6 +3632,8 @@ int uart_get_rs485_mode(struct uart_port *port) > if (IS_ERR(desc)) > return dev_err_probe(dev, PTR_ERR(desc), "Cannot get rs485-rx-during-tx-gpios\n"); > port->rs485_rx_during_tx_gpio = desc; > + if (port->rs485_rx_during_tx_gpio) > + port->rs485_supported.flags |= SER_RS485_RX_DURING_TX; > > return 0; > } Reviewed-by: Ilpo Järvinen -- i. --8323329-1849002651-1702291025=:1867--