From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755228AbeARIyM (ORCPT <rfc822;w@1wt.eu>);
        Thu, 18 Jan 2018 03:54:12 -0500
Received: from foss.arm.com ([217.140.101.70]:51978 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755250AbeARIyK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 18 Jan 2018 03:54:10 -0500
Subject: Re: [PATCH] irqdomain: provide useful debugging information for irq
 domain
To: "Yang, Shunyong" <shunyong.yang@hxt-semitech.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Zheng, Joey" <yu.zheng@hxt-semitech.com>
References: <1516163877-32396-1-git-send-email-shunyong.yang@hxt-semitech.com>
 <210f90d0-1588-2185-4845-d5d143183621@arm.com>
 <alpine.DEB.2.20.1801171018000.1777@nanos>
 <1516181177.3280.13.camel@hxt-semitech.com>
 <alpine.DEB.2.20.1801171032490.1777@nanos>
 <1516182426.3280.19.camel@hxt-semitech.com>
 <alpine.DEB.2.20.1801171056330.1777@nanos>
 <1516184428.3280.25.camel@hxt-semitech.com>
 <d3526488-6706-22d4-1d50-6c595f6f5d3f@arm.com>
 <1516240404.15644.23.camel@hxt-semitech.com>
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <f12b7b93-cf0e-d246-224a-2eb791a9d718@arm.com>
Date: Thu, 18 Jan 2018 08:54:07 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <1516240404.15644.23.camel@hxt-semitech.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 18/01/18 01:53, Yang, Shunyong wrote:
> Hi, Marc
> 
> On Wed, 2018-01-17 at 10:43 +0000, Marc Zyngier wrote:
>> On 17/01/18 10:20, Yang, Shunyong wrote:
>>>
>>> Hi, Thomas and Marc,
>>>
>>> On Wed, 2018-01-17 at 11:01 +0100, Thomas Gleixner wrote:
>>>>
>>>> On Wed, 17 Jan 2018, Yang, Shunyong wrote:
>>>>>
>>>>>
>>>>> On Wed, 2018-01-17 at 10:33 +0100, Thomas Gleixner wrote:
>>>>>>
>>>>>>
>>>>>> And how is that different from:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> The nodes under debugfs irq/irqs describes information of
>>>>>>> every
>>>>>>> single
>>>>>>> irq.
>>>>>> Not at all. It contains the complete hierarchical information
>>>>>> of
>>>>>> each
>>>>>> virq.
>>>>>>
>>>>> I think irq_domain_mapping can provide some high-level
>>>>> information
>>>>> in a
>>>>> summary style.
>>>>> For example, we can check all the IRQs connect to a specific
>>>>> irq
>>>>> chip
>>>>> or irq domain.
>>>> You can retrieve the same information from the irq/irqs files.
>>>> All it
>>>> takes
>>>> is a shell script.
>>>>
>>>> Aside of that with hierarchical irq domains the old debug output
>>>> is
>>>> just
>>>> useless.
>>>>
>>> Umm...Agree. Need I post a patch to remove it?
>> I'm on it.
>>
> In addition to the "%p" to "%px" change in IRQ_DOMAIN_DEBUG you have
> posted patch to remove it, my original patch includes several other
> changes:
> 1. change to "%px" in kasprintf() parameters in
> function __irq_domain_alloc_fwnode() to build name which reflects the
> real pointer address from caller, this may be useful when reading debug
> information.
>  
> n = kasprintf(GFP_KERNEL, "irqchip@%px", data);

Have you investigated whether %pK would work in a debug context?

> 
> 2. other 3 changes from "%p" to "%px" in existing pr_debug().
> 
> Could I submit a V2 patch which depends on your "irqdomain: Kill
> CONFIG_IRQ_DOMAIN_DEBUG" patch to handle this? 
> Following is the link of your patch,
> https://patchwork.kernel.org/patch/10169367/ 

Sure. If you think something is missing, feel free to send an additional
patch.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...