Re: [PATCH v2 2/3] mm/mglru: add tracepoint for scan_folios()

[Ridong Chen <ridong.chen@linux.dev>]

On 9/17/2026 9:23 AM, Baoquan He wrote:
> On 09/16/26 at 09:51am, Steven Rostedt wrote:
>> On Wed, 16 Sep 2026 10:14:31 +0800
>> Baoquan He <baoquan.he@linux.dev> wrote:
>>
>>>> However, 'sc' is an internal structure, so sc->order cannot be accessed in
>>>> TP_fast_assign(), and I don't think it is worth making scan_control an
>>>> external structure just for this.
>>>
>>> Agree.
>>
>> Or what you can do is to move include/trace/events/vmscan.h to
>> mm/trace_mm.h (or whatever you want to call it) and struct scan_control
>> into "vmscan.h" and then you can use internal structures within the
>> trace event.
> 
> Sounds very reasonable, thanks for the valuable input.
> 
>>
>> Up to you, but this is what other subsystems have done.
> 
> Yeah, leave this to Ridong to decide.

Thank you for the suggestion.

I think it is worth doing. And we can also use that for other tracepoints that 
are using sc->*.

I will give this approach a try.

-- 
Best regards
Ridong