mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Chen Lifu <chenlifu@huawei.com>,
	pbonzini@redhat.com, shuah@kernel.org, bgardon@google.com,
	wangyanan55@huawei.com, axelrasmussen@google.com,
	drjones@redhat.com, seanjc@google.com, vkuznets@redhat.com,
	dwmw@amazon.co.uk, joao.m.martins@oracle.com,
	yangyingliang@huawei.com, kvm@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH -next 1/2] selftests: Fix vm_handle_exception undefined error
Date: Fri, 13 Aug 2021 11:01:16 -0600	[thread overview]
Message-ID: <f130f6ec-0c80-7a83-fad2-7d72d389b96b@linuxfoundation.org> (raw)
In-Reply-To: <20210709063741.355325-1-chenlifu@huawei.com>

On 7/9/21 12:37 AM, Chen Lifu wrote:
> Compile setftests on x86_64 occurs following error:
> make -C tools/testing/selftests
> ...
> 
> x86_64/hyperv_features.c:618:2: warning: implicit declaration of function ‘vm_handle_exception’ [-Wimplicit-function-declaration]
>    618 |  vm_handle_exception(vm, GP_VECTOR, guest_gp_handler);
> /usr/bin/ld: /tmp/cclOnpml.o: in function `main':
> tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception'
> collect2: error: ld returned 1 exit status
> 
> The reason is that commit b78f4a596692 ("KVM: selftests: Rename vm_handle_exception")
> renamed "vm_handle_exception" function to "vm_install_exception_handler" function.
> 
> Fix it by replacing "vm_handle_exception" with "vm_install_exception_handler"
> in corresponding selftests files.
> 
> Signed-off-by: Chen Lifu <chenlifu@huawei.com>
> ---
>   tools/testing/selftests/kvm/x86_64/hyperv_features.c | 2 +-
>   tools/testing/selftests/kvm/x86_64/mmu_role_test.c   | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 


Please include kvm in the commit summary. I think it is not getting
the right attention because of the summary line.

Same for the second patch in this series.

thanks,
-- Shuah

  parent reply	other threads:[~2021-08-13 17:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09  6:37 Chen Lifu
2021-07-09  6:37 ` [PATCH -next 2/2] selftests: Fix fscanf warning Chen Lifu
2021-08-13  7:27   ` ping//Re: " chenlifu
2021-08-13 17:01 ` Shuah Khan [this message]
2021-08-13 23:26   ` [PATCH -next 1/2] selftests: Fix vm_handle_exception undefined error Paolo Bonzini
2021-08-16  2:53     ` chenlifu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f130f6ec-0c80-7a83-fad2-7d72d389b96b@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=axelrasmussen@google.com \
    --cc=bgardon@google.com \
    --cc=chenlifu@huawei.com \
    --cc=drjones@redhat.com \
    --cc=dwmw@amazon.co.uk \
    --cc=joao.m.martins@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=shuah@kernel.org \
    --cc=vkuznets@redhat.com \
    --cc=wangyanan55@huawei.com \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®