From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD68DC10F28 for ; Sun, 8 Mar 2020 23:07:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE2E420684 for ; Sun, 8 Mar 2020 23:07:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726491AbgCHXHI (ORCPT ); Sun, 8 Mar 2020 19:07:08 -0400 Received: from smtprelay0111.hostedemail.com ([216.40.44.111]:60162 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726354AbgCHXHH (ORCPT ); Sun, 8 Mar 2020 19:07:07 -0400 Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave05.hostedemail.com (Postfix) with ESMTP id D00E018028203 for ; Sun, 8 Mar 2020 23:07:06 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 1F50C4FFA; Sun, 8 Mar 2020 23:07:06 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: alarm80_77fb7776f6e04 X-Filterd-Recvd-Size: 2174 Received: from XPS-9350.home (unknown [47.151.143.254]) (Authenticated sender: joe@perches.com) by omf16.hostedemail.com (Postfix) with ESMTPA; Sun, 8 Mar 2020 23:07:04 +0000 (UTC) Message-ID: Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operators From: Joe Perches To: Shreeya Patel , gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, sbrivio@redhat.com, daniel.baluta@gmail.com, nramas@linux.microsoft.com, hverkuil@xs4all.nl, Larry.Finger@lwfinger.net Date: Sun, 08 Mar 2020 16:05:25 -0700 In-Reply-To: <20200308220004.9960-1-shreeya.patel23498@gmail.com> References: <20200308220004.9960-1-shreeya.patel23498@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote: > Add space around operators for improving the code > readability. Hello again Shreeya. The subject isn't really quite appropriate as you are not doing this space around operator addition for the entire subsystem. IMO, the subject should be: [PATCH] staging: rtl8188eu: rtw_mlme: Add spaces around operators because you are only performing this change on this single file. If you were to do this for every single file in the subsystem, you could have many individual patches with the exact same subject line. And it would be good to show in the changelog that you have compiled the file pre and post patch without object code change. Also, it's good to show that git diff -w shows no source file changes. > Reported by checkpatch.pl > > Signed-off-by: Shreeya Patel > --- > drivers/staging/rtl8188eu/core/rtw_mlme.c | 40 +++++++++++------------ > 1 file changed, 20 insertions(+), 20 deletions(-) When I try this using checkpatch --fix-inplace, I get 21 changes against the latest -next tree. What tree are you doing this against?