From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932835AbdHVMxO (ORCPT <rfc822;w@1wt.eu>);
        Tue, 22 Aug 2017 08:53:14 -0400
Received: from mout.web.de ([212.227.15.3]:58219 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932720AbdHVMxM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Aug 2017 08:53:12 -0400
Subject: Re: ALSA: pcsp: Use common error handling code in
 snd_card_pcsp_probe()
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
        Jaroslav Kysela <perex@perex.cz>, kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
References: <08ee0d6b-788b-2845-6964-e1e55c2d2292@users.sourceforge.net>
 <20170822121625.syvr64kwyh5xjexg@mwanda> <s5hziar9483.wl-tiwai@suse.de>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <f138ba40-a61f-cdab-3d9b-699dbcacad9d@users.sourceforge.net>
Date: Tue, 22 Aug 2017 14:47:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <s5hziar9483.wl-tiwai@suse.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:7Q+2Fpu3pJGZwm/lOq/LllBsSJZSjUKoDNryi65aDkY2ZAeHpE8
 omq/NPQUjxeupkQIehtyYwiMy3K15rDDcHNeyHGQqjyCpjDOBrVOw/4NyuEycqPY6HqKISg
 L1OZ8xltt+UIDz+G1KYrKtbMFIgJXeHy7T7n8QjtMgz38oXkdZ3k995ZbABMjfgnG1q4kJN
 enSPBgtLF+dCR32kGvYPw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:Zxv5TDKECSc=:qESwdjQLOzkcTV7ruUEohM
 lSp4seeDLpP0qdeCZzd/gzbAg8b67tCRc0BCHckgZSWy2A0xiOSNODymGrOdBtA4bld6SwhWz
 uI9XyqT0J+YKqfzcQaaw0Bad/xHrAtPqUsxY3IS3MgY+C/+3Tpjn7IT2dgI0RjQSXxrdguh2O
 8StUSuEVC9rJrCbeq7v65neq88Y/Rxk2Q+FHeT6f8mYRqCDosPCqy0V3+qqItUmZJ3quuLb7J
 r7keDDpFCU6JEwXmyLMRr6UrLdDJPj9xp8E1zYjxjscJqjJ/DCqgdt/FnT3AmQyLCoPh0JJLS
 /9SiFwoCP5I9BtyBIJ1iVUXn2/vtVc4PeITJat8Pg/5qqubcERb1X1lRQjnLLro5kQa8U5uPP
 KKQi1U2i9SNW/ot7y8uiF2ii8bCskaOL1c6cs9ZqaX7aIdWOC0/XlRtwtYAn4TBHZ2UFObuhX
 g2j/NlgVPTjOU+8ywlNuMb++Y1nubzK1nNT+I/Jd801LBJuF1WO0MDfV2nN8iHDpA6WGA7Nxj
 WOolCFVCGVcd2sDCIo/9vi+QmHB9HGkd7Ogt61safk/ma8fnMCbPB8BDQmrH55RAOTf9hdRFh
 d2FPZEu+t8DCKzelvbl7S8YnJbhrkIX3SFeWpshgMZdqThcN9B63OpKY3XcqQCRRrXczZDTln
 X7CrCmRAgT+YF2+fSH2f0raZdwCLtCmeWwG3Rn0pSgBYkOSznIWgQC5eila0rdP6ZWLmyyYLl
 p32bZ8JqFP75xnktWUkE5gTwJNKS0Ne6Ehaos7HntOFT70dV/UVgCRGQQcKaMgLPl6o0cwZmw
 tWmu0TPUSd08jI+rF+luq/rHSmc/+RaIBiMZ2CffgavRoPnoBA7NqnIsQAuy90Cr/fv/ipu
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Also, please don't omit the negative value check.

Is it appropriate to treat non-zero values as error codes there generally?

Regards,
Markus