From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42ADF41D10E for ; Mon, 17 Aug 2026 12:38:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786970338; cv=none; b=UFpRDgioqCZZEdWUVPFgB0+qbZC4kOcjXmVd3VtDeYPYf02oErIMjXJVwDX+76ZfRwQG7CNI7MY6yRJattFP+xFqwKO+hbcrptvLWUIL8aERxLNS7jY4Y9AI1IOKXrtr3wf9TXH83CXdf28ZnRSjifF5sj5xKpBHJnehdu7De/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786970338; c=relaxed/simple; bh=KYx3mX+tRxRFaAr2MGjO0ScJYuXqBRBzixjQqV5/Tko=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pBX5iYmEidwWeoFn+mUnh0vCLo34EsjXyGCewisjVURfMViaHEDb2RL2fH8GMcTDwpeO2/LeI8ZYEbIcdfPNzPXMDA1wWbEj8tK6ZFr3nSpLyrf37OHN42TZZnhffoLhSsiIunOgBtm5OcsogxnTz53FWHNvXoVWVyM2CZqLZIk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EJho7w71; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eW+pijVf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EJho7w71"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eW+pijVf" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67HCA7Hl1871477 for ; Mon, 17 Aug 2026 12:38:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zzZHJBJkIIxfrqdLYm/z/DMmA8vst/cUsQ96Y/1xjDg=; b=EJho7w71vafwzMhR 3ArrlxASDAsklAfAiIfKUsgBzQ8g7XpcZ9bmPNijpyDquj5IOGQAbWFdHwcQQaCb NxxIsaF+m/49zxIptgMlYU3N1Bqs0Dm9dZ/+2LIrLMCqYpdJC0LKnURdBZbIde8l pfYnMgeF1jTeUPjyBrLUGjIBB5D0AL2EbR+A5IUA8UKfI5jqayfwp85Vb8vwiRWb BVeWK1+AKyNBYwrVTXMFji4fiz7TQ9m5N05umRocXHRAdn0/IWEdMkEGeuZ11+vF SkLlaC3c4EpdE093hNSoQvpfDMYh+lDjIW8pdHTlCPmiVsPcgbfSlB7SyezZiLhM 1g/4xw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g3xb1h0sq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Aug 2026 12:38:52 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51e9d892f0dso9833411cf.2 for ; Mon, 17 Aug 2026 05:38:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786970331; x=1787575131; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zzZHJBJkIIxfrqdLYm/z/DMmA8vst/cUsQ96Y/1xjDg=; b=eW+pijVf+fpTNPLSK+VBffzuHferXO+bdlJdaGFxwfTnLMq7lMrQ3GWye6dmeThLl2 pCB9wwwQX9laRBNC2PQkzK0Cxn3tbVtQJTF0ce371CvTdTyqO8+lpnIhgyLAY1hpetJ7 a6LCRmKO0SYYYfeh7VjwuWRzy+8iZ+FGL1JywaGsig+jTtQAL+b5gpPnsG4pIz2pA9t6 ofpGcxsi6sJoQ81s4019HELTQTC2I6NNVX2JIglYCqaHaLyDfc09X9gWExPK4fsDcPcQ sapav463laIvzB7+vcZhJHN/JZaGTEB31aGmyC+W4OkJwgv9/19+Kx+8EC/XIEWhdn4D FaFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786970331; x=1787575131; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zzZHJBJkIIxfrqdLYm/z/DMmA8vst/cUsQ96Y/1xjDg=; b=kMleC06rkgmGDuUCvn4/2mvlcwTClE6AV7k8W/Zuj4F4TxeBLfLdL9z4rqiE3Q4x5y S+8RA4QOhoZlaXsX8CIy08Tx9ngcTXtES2K0OINkMBw5ws/4niKEdJS9n1DC11vfp7eh 0fcsDuimK0KaS2ytBILPzjxCC2BS49+blOqjLwH+EhmtlQ/NYON/OsqONHLUVdlV3M5R swlZzt+PJTXk4GsSlle4ONTbnZBMTBujrO0uNtVESdmhN/Zg1ujmKOxGTTh2ECPzsBlW NyDqzEOSwMV13ooeqQr7ZvYBxW+sdOO56agzwi7aNtVZ7ywHKIYzCOrOnW8gzSp+/YzD vaKw== X-Forwarded-Encrypted: i=1; AHgh+Rp9qWJoadP7VW33yF1Sr7yYvDod4x9EudaU2/czZP7Grf+6jNIeykHQv0SflM66nUiFpXl1V4LAwZ3u1Sc=@vger.kernel.org X-Gm-Message-State: AOJu0YzYoGshKvn2ceObI/5yaQj9W5QUKGmfayoeoZYDMKooAzuEQygQ xUIrgBSsKMJlUYWgGNxziPoIqNotBJAd6lLOSHzwQQSp71QgNH76q1zUp/WHjJUMWGmbJ8iYhO8 1ykTZp14wqUMkSNCGA78ATk0am4omXckIcUBO8L2+qWe91OeMbbNckk9smYf060yeFdQ= X-Gm-Gg: AR+sD12eSlgfDmqpwKEo7/I8ye83uizCCcOlLP153FoF6P2JMvupWnXRCPoIo6PvSQv KkIVZB4evDyKeZbimFxaBN9JfV9uuKLuBzX1o0PbFWQAA2IRO0IbZIRqQlsj8nDQvjZAmMvzl+M hYERZrDsbr9zrcZm8lrcsnxx2b8EN9Nfz2jM5/qPb1c8gNIhMqE2TFxG6r1BKAg1AZPekKSJGXZ NTyqvqF6A9WbQ4qjKSr7Z4kHuLQdmoi2cq34PELSZq/MHtReC5Rrrbn0SHZYzbmPn8BajvtBR3u zSRnDCM4UWxodB2AVJwAWnmySyPsAd4f6l9gWxs7cEHvCwZsgpaFCDdWaMqHtSwkOynvtTPSaoT 2WX7vwDWzmdNkh7Ax2Dpvggk/ X-Received: by 2002:ac8:58c9:0:b0:51c:10e9:ec47 with SMTP id d75a77b69052e-52d85529b51mr185899261cf.5.1786970331331; Mon, 17 Aug 2026 05:38:51 -0700 (PDT) X-Received: by 2002:ac8:58c9:0:b0:51c:10e9:ec47 with SMTP id d75a77b69052e-52d85529b51mr185898611cf.5.1786970330791; Mon, 17 Aug 2026 05:38:50 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3a16b1bcdd7sm4280841fa.33.2026.08.17.05.38.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Aug 2026 05:38:49 -0700 (PDT) Message-ID: Date: Mon, 17 Aug 2026 14:38:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/14] dt-bindings: phy: Document the Qualcomm IPQ5332 UNIPHY USB Super-speed PHY To: Krzysztof Kozlowski , George Moussalem Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Praveenkumar I , Varadarajan Narayanan , Philipp Zabel , Bjorn Andersson , Konrad Dybcio , Greg Kroah-Hartman , Wesley Cheng , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <20260812-ipq5018-usb3-v2-0-8f355d7ff0ef@outlook.com> <20260812-ipq5018-usb3-v2-1-8f355d7ff0ef@outlook.com> <20260813-alluring-advanced-jackalope-55e5c1@quoll> <71cfe76b-ea84-47f8-9ff7-945d69efbdcd@kernel.org> <34503ae2-9c89-4773-af80-fa7b7439ff23@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <34503ae2-9c89-4773-af80-fa7b7439ff23@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Ua9hjqSN c=1 sm=1 tr=0 ts=6a8300dc cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=UszWgs0Efp_EzN_vPCIA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: aRESrY8CRGivfjQoSiRUHVbAhScIU2KQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE3MDA5NiBTYWx0ZWRfX/1EMmBOeR5vi wgX1xs2lKidShQn7iJiie3+w3908AxYJ7w6HCdsDuYuutwc//CjSIFQ/ZEaEgg3BL9HgQ6ihTFQ RMyI0sUHXzFd80ZYmayIbbmvnHl+LBzbUa6lfedcv//3MkQ5BdbQs1YvLvJL5h3zMLa36rvyHxV BVGAdMmK/Z8Jj/HF6xwZIaBrxZvFrVHsqaXtJoId9v3rVlQD7D6s7socU+mht8BQ229j+BM9/S9 wAzt43KxHTEJSi94HfX6cNOr2dUdF5tFcmQjn+IhQUEmIJEFqAiZ7iLKNSNl4xqih/cFltmmITO b68iWGhrcvG+87iejESaJ6PCRWjK2RcqC+2ISU0VnRToUBIXLhnqS6c+IJ3f8XTmJNfTrY7EG64 ul4pEhW1a2//AObJ1ymQBn7ELoWejfo59bXH6+QxZRi6dFDmfdZv4/cbk0+esQq2Mu3ZG3Zi5YY KJf4Kge04a4VU4/wsYQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwODE3MDA5NiBTYWx0ZWRfX9cgRoWDzduO/ bYsdJC44EnDPtOWSoVNo5zPwe+yme0yUf2UaVAgOFpNA9xJS3E4RTEDylXMxCagDtf0XE2H43Al A8My5EiT2cbN/qX1Wn0NLI7I03+1Qk4= X-Proofpoint-ORIG-GUID: aRESrY8CRGivfjQoSiRUHVbAhScIU2KQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-17_01,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608170096 On 8/17/26 2:37 PM, Konrad Dybcio wrote: > On 8/13/26 12:48 PM, Krzysztof Kozlowski wrote: >> On 13/08/2026 12:28, George Moussalem wrote: >>>>> +examples: >>>>> + - | >>>>> + #include >>>>> + >>>>> + phy@4b0000 { >>>>> + compatible = "qcom,ipq5332-uniphy-usb-ss-phy"; >>>>> + reg = <0x4b0000 0x800>; >>>> >>>> That is the same address as PCI PHY, so you have one device, not two. >>> >>> yes, AFAIK they're separate PHYs (pcie-28lp vs usb-ss-22ull) sharing the >>> same MMIO register space in IPQ5332. To enable USB3, the compatible >>> string, clocks, resets, and related USB3 properties override the PCIe >>> properties. In IPQ5018, the PHYs have different register address spaces, >>> hence representing it as a new devicetree node. >>> >> >> Same MMIO space is same device, IMO, especially that you have the same >> registers (looking at the driver). > > It's indeed one device, fittingly named "PCIE+USB COMBO PHY" so the implementation, matching prior art for similar cases should be: - phy node with #phy-cells = <1> - consumer takes a reference through phys = <&phy FOO_PCIE> or FOO_USB3 - new driver in drivers/phy/qualcomm to coordinate the two modes Konrad