From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 629EB3AA4FC for ; Fri, 27 Mar 2026 10:11:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774606289; cv=none; b=aBVOMTUFXqCKDBwJqf6lV2UglukfLW9mfsm0cg+oahTCMIkLZa0G5JM0L5DTv0XY9mfPlbQfPe1BATiJ50QES3S+bHpva0oGd0Td3o35nr6KHfUbt5g74xR7hYUdErUl22cyk4rnRG/eI25kV/yyfriJrnFPW9++kunl7W2NdQQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774606289; c=relaxed/simple; bh=UePfgCVIMdwnsiSP/Ict/OfV+6Z2KDwQBisMnTe2L64=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VYw9kFm0ADi01T6DWD+GCWzDrBM8BdWeXob7SUjNH3TDXsH2iZpKeBxWWjzgWZZcSSdDqBrx/zYxh7QhASUNOU5RsZRqqnELPoEt6jiR5NcMx2ZZJsHWTQ1yYoXtHrxOShXoMF/9/RJac0lquP5rjJZNCpp4Hh1xSwgV33CCZeI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SixYxoVF; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=rfN200iY; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SixYxoVF"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="rfN200iY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774606287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KRnbNl3u/p+FGuGPfwMKlR/+7x5aDIRiANz+ZN11JbI=; b=SixYxoVFpWQLizb10A41rXjR40DkUpvCHyTySPbY382LJxS4ZXgHXw/4AWoKMM87bkGMz2 pJmfVi+Qsymm25FRbr7An2GSZTaNSVjWUOFslcUM0rNRv/+/3nRx7al0wPvJZooqmb+Rbe pFLvZWGlLal/tfwiQrxtXnQTiOMCj+A= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-dJ4jqtXMOku8thOAcwdPIw-1; Fri, 27 Mar 2026 06:11:26 -0400 X-MC-Unique: dJ4jqtXMOku8thOAcwdPIw-1 X-Mimecast-MFC-AGG-ID: dJ4jqtXMOku8thOAcwdPIw_1774606285 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-486fb142205so24547485e9.1 for ; Fri, 27 Mar 2026 03:11:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774606283; x=1775211083; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KRnbNl3u/p+FGuGPfwMKlR/+7x5aDIRiANz+ZN11JbI=; b=rfN200iYHV/Q6TjOW5iZxFpIdUoAvfcbQzTlg3n2ITZPxlZ/zR3rQhmqroSUF+oVOI PANE9eon12ffa+mLxsz3Fx53B2zXKoMNO4pqVvKi+x8vcaT6H70X4OjjlJnbdqvYh5vL EhI3EFCr4zgK3A5WeOEfXBI1X/N3T6BjNqrDSlhcsg24cCV6MjFsz5p6GymWDdZsW95s Hc8tw+kXmtOupERqdLsX9nhDQz4vvu03q/Jc9qAWdQYA2PaCbNOTh1p/QZ3jSIbAXCib Oefrjtf+GTWT1kJfARR/aoC7IP5JSg/EkPMLvqLPIxD9NOVTC2cVybs5XPecCKa2PHuh N5dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774606283; x=1775211083; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KRnbNl3u/p+FGuGPfwMKlR/+7x5aDIRiANz+ZN11JbI=; b=BAxYJDYWUnXvH/MmqieEljroRqEZB8r2cCcv+KxFhu4J7KYi9jjLXkS2xsuvR6a/c9 vVlGgykNCeAzQuXsE6UdYNLC7iSZ0yOtTxE4coN+VmyOVIyoKU01FbJYXyX5OdPUMpqG ioQvwAeQmRPECrkFV6bvR+E6CVKy8Zhjz1dJYlG1yejL/hsKf3evUthcmRp1DcJmvb7p aoZnsxbRd3Jfejih26DQW7u/CE2R6GffIdQAGlbn5NMUPYMMwysdTMLuOJk+FwA34ln7 ciQRm6hda/aeysjWOexts+tTjVtbirdf+J6byWmhRG7g5xHaQPjc90fcbR6Q7bhc55JS 4qZA== X-Forwarded-Encrypted: i=1; AJvYcCUqK/BN+NY+mUvR5yUU963fIUwBNi8al2REhu3ieFU0jb/0qEUouInyNZ+aSKRlO7Hsqz5iO5ry/TOBmFI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6ODnSvnlQALkncuL74gsbMhWpAhkMcIWodHG9wOsTEhlUkOcn 889CgfolidIxADV5LcRIpdkCHjkWzhJ3TkwMxMZ79kyhh9JOHVWiFV/IDRqwukc85anVvBp9c8b 5XIafflru7q2Mx1KRyxGL4YZWyAg1XWWiB7I39Pf8NDqmphNka7LtnOFiWenCctWqPVHZXCHFmr Ce X-Gm-Gg: ATEYQzymkWbwyzBdXn/ZjPZYE4ZE1u1TiGqrgt8xVZgIGhzYP93TFjD0iBHRwEkV8Xa 3CmWFEJbTg5ShkCRWGY3hE3UL9Xjxh6q9x9NUpYee1tEYorb0Mxbt+BHXUGgvFVQQf2fSkzAJ2C CwMO401aQC2A9giLCDK262ASn8VDLJNmkRKldAq/XZF13/cWncATY5oXVXGejL6lLs3T8I8dhE4 j+MwZSWy10iDahaYcZRrtzRO8g5Gl3zf7cVvASttBETjF8OTdedZNsDBE2q/EXA1290jOyfkRZ1 XfB1jfhtiPrYHZWEehRGxfutwM7i0z0y5rJ51XgQ+zX9Fp4lGAEKGl2HyKXcFN0yyUIbRLDLwqq 6cwTrBPGVmc/04ZdMfsoz X-Received: by 2002:a05:600c:3b24:b0:485:6ec7:2df with SMTP id 5b1f17b1804b1-48727d5f7a5mr27183955e9.8.1774606283092; Fri, 27 Mar 2026 03:11:23 -0700 (PDT) X-Received: by 2002:a05:600c:3b24:b0:485:6ec7:2df with SMTP id 5b1f17b1804b1-48727d5f7a5mr27183455e9.8.1774606282661; Fri, 27 Mar 2026 03:11:22 -0700 (PDT) Received: from [192.168.2.83] ([46.175.183.46]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919e68a6sm16570703f8f.33.2026.03.27.03.11.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2026 03:11:21 -0700 (PDT) Message-ID: Date: Fri, 27 Mar 2026 11:11:20 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/5] dpll: zl3073x: use FIELD_MODIFY() for clear-and-set patterns To: Ivan Vecera , netdev@vger.kernel.org Cc: Arkadiusz Kubalewski , Jiri Pirko , Michal Schmidt , Prathosh Satish , Simon Horman , Vadim Fedorenko , linux-kernel@vger.kernel.org, Conor Dooley , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, Pasi Vaananen References: <20260319174826.7623-1-ivecera@redhat.com> <20260319174826.7623-3-ivecera@redhat.com> Content-Language: en-US From: Petr Oros In-Reply-To: <20260319174826.7623-3-ivecera@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > Replace open-coded clear-and-set bitfield operations with > FIELD_MODIFY(). > > Signed-off-by: Ivan Vecera > --- > drivers/dpll/zl3073x/chan.h | 17 ++++++----------- > drivers/dpll/zl3073x/core.c | 3 +-- > drivers/dpll/zl3073x/flash.c | 3 +-- > 3 files changed, 8 insertions(+), 15 deletions(-) > > diff --git a/drivers/dpll/zl3073x/chan.h b/drivers/dpll/zl3073x/chan.h > index e0f02d3432086..481da2133202b 100644 > --- a/drivers/dpll/zl3073x/chan.h > +++ b/drivers/dpll/zl3073x/chan.h > @@ -66,8 +66,7 @@ static inline u8 zl3073x_chan_ref_get(const struct zl3073x_chan *chan) > */ > static inline void zl3073x_chan_mode_set(struct zl3073x_chan *chan, u8 mode) > { > - chan->mode_refsel &= ~ZL_DPLL_MODE_REFSEL_MODE; > - chan->mode_refsel |= FIELD_PREP(ZL_DPLL_MODE_REFSEL_MODE, mode); > + FIELD_MODIFY(ZL_DPLL_MODE_REFSEL_MODE, &chan->mode_refsel, mode); > } > > /** > @@ -77,8 +76,7 @@ static inline void zl3073x_chan_mode_set(struct zl3073x_chan *chan, u8 mode) > */ > static inline void zl3073x_chan_ref_set(struct zl3073x_chan *chan, u8 ref) > { > - chan->mode_refsel &= ~ZL_DPLL_MODE_REFSEL_REF; > - chan->mode_refsel |= FIELD_PREP(ZL_DPLL_MODE_REFSEL_REF, ref); > + FIELD_MODIFY(ZL_DPLL_MODE_REFSEL_REF, &chan->mode_refsel, ref); > } > > /** > @@ -110,13 +108,10 @@ zl3073x_chan_ref_prio_set(struct zl3073x_chan *chan, u8 ref, u8 prio) > { > u8 *val = &chan->ref_prio[ref / 2]; > > - if (!(ref & 1)) { > - *val &= ~ZL_DPLL_REF_PRIO_REF_P; > - *val |= FIELD_PREP(ZL_DPLL_REF_PRIO_REF_P, prio); > - } else { > - *val &= ~ZL_DPLL_REF_PRIO_REF_N; > - *val |= FIELD_PREP(ZL_DPLL_REF_PRIO_REF_N, prio); > - } > + if (!(ref & 1)) > + FIELD_MODIFY(ZL_DPLL_REF_PRIO_REF_P, val, prio); > + else > + FIELD_MODIFY(ZL_DPLL_REF_PRIO_REF_N, val, prio); > } > > /** > diff --git a/drivers/dpll/zl3073x/core.c b/drivers/dpll/zl3073x/core.c > index 6363002d48d46..7eebfc1ad1019 100644 > --- a/drivers/dpll/zl3073x/core.c > +++ b/drivers/dpll/zl3073x/core.c > @@ -743,8 +743,7 @@ int zl3073x_dev_phase_avg_factor_set(struct zl3073x_dev *zldev, u8 factor) > value = (factor + 1) & 0x0f; > > /* Update phase measurement control register */ > - dpll_meas_ctrl &= ~ZL_DPLL_MEAS_CTRL_AVG_FACTOR; > - dpll_meas_ctrl |= FIELD_PREP(ZL_DPLL_MEAS_CTRL_AVG_FACTOR, value); > + FIELD_MODIFY(ZL_DPLL_MEAS_CTRL_AVG_FACTOR, &dpll_meas_ctrl, value); > rc = zl3073x_write_u8(zldev, ZL_REG_DPLL_MEAS_CTRL, dpll_meas_ctrl); > if (rc) > return rc; > diff --git a/drivers/dpll/zl3073x/flash.c b/drivers/dpll/zl3073x/flash.c > index 83452a77e3e98..f85535c8ad246 100644 > --- a/drivers/dpll/zl3073x/flash.c > +++ b/drivers/dpll/zl3073x/flash.c > @@ -194,8 +194,7 @@ zl3073x_flash_cmd_wait(struct zl3073x_dev *zldev, u32 operation, > if (rc) > return rc; > > - value &= ~ZL_WRITE_FLASH_OP; > - value |= FIELD_PREP(ZL_WRITE_FLASH_OP, operation); > + FIELD_MODIFY(ZL_WRITE_FLASH_OP, &value, operation); > > rc = zl3073x_write_u8(zldev, ZL_REG_WRITE_FLASH, value); > if (rc) LGTM. Reviewed-by: Petr Oros