From: "kondaveeti, Arungopal" <arungopal.kondaveeti@amd.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, vsujithkumar.reddy@amd.com,
Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
Sunil-kumar.Dommati@amd.com, syed.sabakareem@amd.com,
mastan.katragadda@amd.com, "Liam Girdwood" <lgirdwood@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: amd: correct pm_runtime enable sequence
Date: Fri, 16 Jun 2023 18:28:29 +0530 [thread overview]
Message-ID: <f140ae96-a1fd-e636-2b8b-d453fba5c6e2@amd.com> (raw)
In-Reply-To: <317a0f1b-94a7-4bd4-9f64-8877e0552b6a@sirena.org.uk>
On 6/13/2023 7:39 PM, Mark Brown wrote:
> On Wed, Jun 14, 2023 at 06:01:59AM +0530, Arun Gopal Kondaveeti wrote:
>
>> Replace pm_runtime_allow() with pm_runtime_mark_last_busy()
>> & pm_runtime_set_active() in pm_runtime enable sequence for
>> dma drivers.
> This says what the change does but it doesn't say why the old sequence
> was a problem and the new one is better.
pm_runtime_allow is not needed for child platform drivers .
Previous sequence as listed below which is incorrect.
enable sequence:
pm_runtime_set_autosuspend_delay(&pdev->dev, ACP_SUSPEND_DELAY_MS);
pm_runtime_use_autosuspend(&pdev->dev);
pm_runtime_enable(&pdev->dev);
pm_runtime_allow(&pdev->dev);
disable sequence:
pm_runtime_disable(&pdev->dev)
Replaced pm runtime enable sequence.
next prev parent reply other threads:[~2023-06-16 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 0:31 Arun Gopal Kondaveeti
2023-06-13 14:09 ` Mark Brown
2023-06-16 12:58 ` kondaveeti, Arungopal [this message]
2023-06-16 13:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f140ae96-a1fd-e636-2b8b-d453fba5c6e2@amd.com \
--to=arungopal.kondaveeti@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mastan.katragadda@amd.com \
--cc=nicolas.ferre@microchip.com \
--cc=perex@perex.cz \
--cc=syed.sabakareem@amd.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vsujithkumar.reddy@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®