From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17742C38142 for ; Tue, 24 Jan 2023 15:18:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234335AbjAXPSD (ORCPT ); Tue, 24 Jan 2023 10:18:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233590AbjAXPR7 (ORCPT ); Tue, 24 Jan 2023 10:17:59 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 411CD5FC9 for ; Tue, 24 Jan 2023 07:17:52 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id q5so9553373wrv.0 for ; Tue, 24 Jan 2023 07:17:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=P2VSIRQ0sM1vpHuf8rla2J/YgrIDXTW4aHVMtNxKuzs=; b=E0vtUfGK8Xgmn95qAj3P+4mKS2op5T6PfCq/IoA3n3HfdQ143BRpsqzwpCdU1JDSoR XdkZfIWTqv7xfBwmxEmitd7mqjwpIc3/onc81/cvxT8LyUYQkAq4pd1bq3Hoikqzw7t+ ZdzRdS3gBlWoTpM5jVLcydnUdC4DcYfpLrYD9zehs/8ZDjbq4ABgjs0NrtRCbg97z9aq gY0UHZdcwvYYIpGgszUQVqNUDCD6wp0VGQxk81C/4RMEiTiynDbQ3yYd05FEWDASMrsM CnntpL95bt90ccpOBbj8xwehvPTRoaTaA48VtgIzU8eisp1XvloCZJdB5uwP+D7xLXO0 fUug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P2VSIRQ0sM1vpHuf8rla2J/YgrIDXTW4aHVMtNxKuzs=; b=pZu3MI3e0PDJ95VWTVtj5jWr6Yhci5fgYmwmwR40ByG0+H6edpYlSQMEeST5q8g+eE VwbZt5E9cuRUjBXnhH8lfGN6juBkAZztUuQJNxOpYD7XorUJZqu3qX7XDiok7TojA1Tb IHYCbpkN2yjbEUB19i0H5UPVNNSrOFf0EbJYOfrSKxgDLfSlyzQVLG5VovwrZOpH9Dcj pw2b4WgxghEpMbiP1z9WIZkT5M4xAETys69Ququ2tljQpNAmjYxkz8Ip9hIHs1+bMZq2 Nv7ujmzT4KT39KSXZfGlX/yZC+94xEVS4TIN7yKZCNUx83QyuM74RJYmlGciznp+e2qp 1CkA== X-Gm-Message-State: AFqh2kqiHCVnL6dv68zD4jgsKcGtXDU7HQwrNuxaZjH/7bJbYRuIc0cf nfiJg7jmEA+NKCRHyETJtwzqRQ== X-Google-Smtp-Source: AMrXdXsf+Cciqhme9ccOuJdxb626GrgOW7aBLMFfulcKCQgwB+siVPDLksLuWgH9yLYS2T/mc64t4g== X-Received: by 2002:adf:c7cb:0:b0:2bc:48b3:f6de with SMTP id y11-20020adfc7cb000000b002bc48b3f6demr29408935wrg.0.1674573470736; Tue, 24 Jan 2023 07:17:50 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id r1-20020a0560001b8100b002bfae16ee2fsm2024181wru.111.2023.01.24.07.17.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jan 2023 07:17:50 -0800 (PST) Message-ID: Date: Tue, 24 Jan 2023 16:17:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH linux-next v4 4/4] dt-bindings: usb: Fix device tree binding for VL817 hub controller Content-Language: en-US To: Anand Moon , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski Cc: linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230124144054.13556-1-linux.amoon@gmail.com> <20230124144054.13556-5-linux.amoon@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230124144054.13556-5-linux.amoon@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/01/2023 15:40, Anand Moon wrote: > Cleanup by removing unneeded quotes from refs and > add maxItems to reset-gpios and fix the required list. > > Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller") > Reviewed-by: Krzysztof Kozlowski I think it's the first time I see this patch. Where did I review it? Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). Subject: drop second/last, redundant "device tree binding for". The "dt-bindings" prefix is already stating that these are bindings. > Signed-off-by: Anand Moon > --- > .../devicetree/bindings/usb/vialab,vl817.yaml | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/vialab,vl817.yaml b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml > index 5f9771e22058..23a13e1d5c7a 100644 > --- a/Documentation/devicetree/bindings/usb/vialab,vl817.yaml > +++ b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml Best regards, Krzysztof