From: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
To: Maarten Lankhorst <dev@lankhorst.se>,
Maciej Falkowski <maciej.falkowski@linux.intel.com>,
Oded Gabbay <ogabbay@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-rt-devel@lists.linux.dev
Subject: Re: [PATCH] accel/ivpu: Remove lockdep_assert_irqs_disabled()
Date: Tue, 22 Jul 2025 09:53:46 +0200 [thread overview]
Message-ID: <f14e9187-e3b1-494d-b04f-9e7875a17e5a@linux.intel.com> (raw)
In-Reply-To: <20250715165919.33754-1-dev@lankhorst.se>
Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
On 7/15/2025 6:59 PM, Maarten Lankhorst wrote:
> This breaks on PREEMPT_RT, and should be unneeded since
> lockdep can track irq disabled status itself.
>
> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
> ---
> drivers/accel/ivpu/ivpu_ipc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_ipc.c b/drivers/accel/ivpu/ivpu_ipc.c
> index 39f83225c1815..5f00809d448af 100644
> --- a/drivers/accel/ivpu/ivpu_ipc.c
> +++ b/drivers/accel/ivpu/ivpu_ipc.c
> @@ -141,7 +141,6 @@ ivpu_ipc_rx_msg_add(struct ivpu_device *vdev, struct ivpu_ipc_consumer *cons,
> struct ivpu_ipc_rx_msg *rx_msg;
>
> lockdep_assert_held(&ipc->cons_lock);
> - lockdep_assert_irqs_disabled();
>
> rx_msg = kzalloc(sizeof(*rx_msg), GFP_ATOMIC);
> if (!rx_msg) {
next prev parent reply other threads:[~2025-07-22 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 16:59 Maarten Lankhorst
2025-07-22 7:53 ` Jacek Lawrynowicz [this message]
2025-07-22 8:28 ` Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f14e9187-e3b1-494d-b04f-9e7875a17e5a@linux.intel.com \
--to=jacek.lawrynowicz@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=clrkwllms@kernel.org \
--cc=dev@lankhorst.se \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=maciej.falkowski@linux.intel.com \
--cc=ogabbay@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®