From: Bart Van Assche <bvanassche@acm.org>
To: Qian Cai <cai@lca.pw>, tj@kernel.org, jiangshanlai@gmail.com
Cc: peterz@infradead.org, mingo@redhat.com, will.deacon@arm.com,
catalin.marinas@arm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] workqueue: fix a memory leak in wq->lock_name
Date: Sun, 3 Mar 2019 10:19:40 -0800 [thread overview]
Message-ID: <f14f8b87-d55a-4ea9-c2d2-9a48d6360aa3@acm.org> (raw)
In-Reply-To: <20190303143452.11629-1-cai@lca.pw>
On 3/3/19 6:34 AM, Qian Cai wrote:
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 497900263dbc..e780bf73eced 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -3445,6 +3445,8 @@ static void wq_init_lockdep(struct workqueue_struct *wq)
> lock_name = kasprintf(GFP_KERNEL, "%s%s", "(wq_completion)", wq->name);
> if (!lock_name)
> lock_name = wq->name;
> +
> + wq->lock_name = lock_name;
> lockdep_init_map(&wq->lockdep_map, lock_name, &wq->key, 0);
> }
Not sure how this got overlooked. Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
prev parent reply other threads:[~2019-03-03 18:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-03 14:34 Qian Cai
2019-03-03 18:19 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f14f8b87-d55a-4ea9-c2d2-9a48d6360aa3@acm.org \
--to=bvanassche@acm.org \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®