From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932263AbcGLNY4 (ORCPT ); Tue, 12 Jul 2016 09:24:56 -0400 Received: from mga02.intel.com ([134.134.136.20]:26747 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbcGLNYz (ORCPT ); Tue, 12 Jul 2016 09:24:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,352,1464678000"; d="scan'208";a="1020137803" Subject: Re: [PATCH v2] relay: Add global mode support for buffer-only channels To: Chris Wilson References: <1468221456-15537-1-git-send-email-akash.goel@intel.com> <20160711131709.4b2417f54b2eb9fd0fa19900@linux-foundation.org> <20160712092445.GN6157@nuc-i3427.alporthouse.com> <62e36dd1-85b3-2fa9-550e-c43780b5b33b@intel.com> <20160712130100.GT6157@nuc-i3427.alporthouse.com> Cc: Andrew Morton , linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, Eduard - Gabriel Munteanu , Tom Zanussi , akash.goel@intel.com From: "Goel, Akash" Message-ID: Date: Tue, 12 Jul 2016 18:54:49 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160712130100.GT6157@nuc-i3427.alporthouse.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/12/2016 6:31 PM, Chris Wilson wrote: > On Tue, Jul 12, 2016 at 06:20:06PM +0530, Goel, Akash wrote: >> Thanks much, will update the documentation as well as the changelog >> as per the above. >> >> But an export of symbol relay_late_setup_files() is still needed, just >> like relay_open() is exported, in order to make it accessible to >> modules like i915 ? > > Yes, we need the companion function in i915.ko. That needs to be > explained in the patch notes to justify adding the EXPORT_SYMBOL. > Otherwise without that context, it looks unnecessary as Andrew objected > to. Won't your suggested updates to Documentation & changelog suffice ?. relay_late_setup_files() is to be used in conjunction with relay_open(), hence need to be exported. Do I also need to provide the corresponding i915 patch, which has a call to relay_late_setup_files() ? Best regards Akash > -Chris >