mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Giovanni Gherdovich <ggherdovich@suse.cz>
To: Christian Loehle <christian.loehle@arm.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>
Cc: Huang Rui <ray.huang@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Pierre Gondois <pierre.gondois@arm.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: Don't track pressure if policy->max equals top of freq_table
Date: Fri, 9 Oct 2026 12:44:10 +0200	[thread overview]
Message-ID: <f15bb2b4-f11e-4e44-959d-11055720d99b@suse.cz> (raw)
In-Reply-To: <32a250e5-0c56-43ce-ab80-8c4375542b59@arm.com>

On Fri Oct 9, 2026 11:40, Christian Loehle wrote:
> On 10/9/26 09:29, Giovanni Gherdovich wrote:
>> The acpi-cpufreq driver stores non-boost frequencies in
>> policy->freq_table, but policy->cpuinfo.max_freq contains the max
>> boost frequency.
>>
>> policy->max is constrained to be, at most, the largest value in
>> freq_table. This means that under nominal conditions, policy->max is
>> substantially lower than policy->cpuinfo.max_freq, resulting in large
>> values of cpufreq_pressure, on all CPUs, for no reason.
> 
> 
> I'm assuming this isn't on top of
> f341dc4d934a ("cpufreq: intel_pstate: Fix max_freq fallback in cpufreq_update_pressure()")
> Care to retry?

Ah! Yes that fixes it.

Pressure is zero on all CPUs under nominal conditions with acpi-cpufreq;
not tracked, as the commit makes it conditional to the driver implementing
.scale_freq.

Thanks Christian for pointing that out.


Giovanni

      reply	other threads:[~2026-10-09 10:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-09  8:29 Giovanni Gherdovich
2026-10-09  9:40 ` Christian Loehle
2026-10-09 10:44   ` Giovanni Gherdovich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f15bb2b4-f11e-4e44-959d-11055720d99b@suse.cz \
    --to=ggherdovich@suse.cz \
    --cc=christian.loehle@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=pierre.gondois@arm.com \
    --cc=rafael@kernel.org \
    --cc=ray.huang@amd.com \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®